Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Change Date Format from UTC to Local Time in combineDatetime #1441

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Dec 3, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • The combineDatetime function is only used to combine local date and times, but the format string was treating the local date and time as UTC, yielding incorrect outputs
  • Removed the [Z] from the end of the format string

Testing Notes

  • When creating an animal capture/mortality event, the displayed date and time should match the event's true date and time (the API responds with local time so the timestamp in the API response should be what is shown on the capture/mortality card)

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.60%. Comparing base (f0cb44e) to head (56d649b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1441   +/-   ##
=======================================
  Coverage   45.60%   45.60%           
=======================================
  Files         845      845           
  Lines       22296    22296           
  Branches     3301     3301           
=======================================
  Hits        10167    10167           
  Misses      11532    11532           
  Partials      597      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mauberti-bc mauberti-bc merged commit 82c8d9f into dev Dec 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants