SIMSBIOHUB-646: Add Device Keys Button to Manage Deployments & Misc UI Updates #1440
Conversation
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## SIMSBIOHUB-627 #1440 +/- ##
==================================================
+ Coverage 45.38% 45.47% +0.08%
==================================================
Files 887 887
Lines 23189 23201 +12
Branches 3376 3383 +7
==================================================
+ Hits 10525 10550 +25
+ Misses 12068 12055 -13
Partials 596 596 ☔ View full report in Codecov by Sentry. |
| @@ -137,6 +138,14 @@ export function createDevice(): RequestHandler { | |||
|
|
|||
| const telemetryDeviceService = new TelemetryDeviceService(connection); | |||
|
|
|||
| // Check whether device already exists in Survey | |||
| const device = await telemetryDeviceService.findDeviceBySerial(surveyId, serial, device_make_id); | |||
There was a problem hiding this comment.
Note: There is already a unique constraint on the device table for (survey_id, serial, device_make_id)
There was a problem hiding this comment.
I did this to catch the would-be error to give a useful error message. I figured this made the goal more obvious rather than waiting for the database error, but let me know if you think we should do it differently.
app/src/features/surveys/telemetry/manage/deployments/form/timeline/DeploymentStartForm.tsx
Outdated
Show resolved
Hide resolved
app/src/features/surveys/telemetry/manage/deployments/table/DeploymentsContainer.tsx
Outdated
Show resolved
Hide resolved
app/src/features/surveys/telemetry/manage/deployments/table/DeploymentsTable.tsx
Outdated
Show resolved
Hide resolved
app/src/features/surveys/telemetry/manage/devices/create/CreateDevicePage.tsx
Outdated
Show resolved
Hide resolved
app/src/features/surveys/telemetry/manage/devices/table/DevicesContainer.tsx
Outdated
Show resolved
Hide resolved
app/src/features/surveys/telemetry/manage/devices/table/DevicesTable.tsx
Outdated
Show resolved
Hide resolved
|
Links to Jira Tickets
Description of Changes