-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-633: Revamp CSV Imports - Critter #1438
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1438 +/- ##
==========================================
+ Coverage 45.65% 45.94% +0.28%
==========================================
Files 842 848 +6
Lines 22268 22444 +176
Branches 3300 3331 +31
==========================================
+ Hits 10167 10312 +145
- Misses 11504 11522 +18
- Partials 597 610 +13 ☔ View full report in Codecov by Sentry. |
api/src/services/import-services/critter/import-critters-service.ts
Outdated
Show resolved
Hide resolved
api/src/services/import-services/critter/critter-header-configs.ts
Outdated
Show resolved
Hide resolved
api/src/services/import-services/critter/critter-header-configs.ts
Outdated
Show resolved
Hide resolved
api/src/services/import-services/critter/import-critters-service.ts
Outdated
Show resolved
Hide resolved
…into mdColumnValidator
Looks great! It's just missing the ability to make headers optional - wildlife health ID and description should be optional when adding animals
|
…into mdColumnValidator
…into mdColumnValidator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
Links to Jira Tickets
Description of Changes
Testing Notes