Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-644: Add pagination, Update toggle group component #1436

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Nov 27, 2024

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-644

Description of Changes

  • Add proper backend pagination to the sampling periods table, on the manage sampling information page.
    • Some minor cleanup/tweaks to related frontend components.
  • Updates to replace uses of ToggleButtonGroup with CustomToggleButtonGroup
  • Removed padding around all of the StyledDataGrid components, and tweaked the styled data grid css to add some additional padding to the left side of the first column (so the content isn't right against the left edge).

Testing Notes

Sampling period table on the manage sampling information page correctly supports pagination.
Toggle button groups throughout the app display/function as normal/expected.

…tion page.

Some minor tweaks to existing related components (tweaks the jsdoc, sorting the props, etc).
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 2.59740% with 75 lines in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (a7bcd49) to head (a838b55).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...rmation/sites/table/SamplingSiteTableContainer.tsx 0.00% 42 Missing ⚠️
app/src/features/standards/StandardsPage.tsx 0.00% 6 Missing ⚠️
...-information/periods/table/SamplingPeriodTable.tsx 0.00% 5 Missing ⚠️
...src/components/toolbar/CustomToggleButtonGroup.tsx 0.00% 4 Missing ⚠️
...tures/summary/list-data/ListDataTableContainer.tsx 0.00% 4 Missing ⚠️
...summary/tabular-data/TabularDataTableContainer.tsx 0.00% 4 Missing ⚠️
...ontainer/SurveyObservationTabularDataContainer.tsx 0.00% 4 Missing ⚠️
...figure-columns/components/ConfigureColumnsPage.tsx 0.00% 2 Missing ⚠️
app/src/features/admin/alert/AlertContainer.tsx 0.00% 1 Missing ⚠️
...n/users/access-requests/AccessRequestContainer.tsx 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1436      +/-   ##
==========================================
+ Coverage   45.60%   45.65%   +0.05%     
==========================================
  Files         845      842       -3     
  Lines       22296    22268      -28     
  Branches     3301     3300       -1     
==========================================
  Hits        10167    10167              
+ Misses      11532    11504      -28     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura marked this pull request as ready for review November 28, 2024 21:57
@NickPhura NickPhura added the Ready For Review PR is ready for review label Nov 28, 2024
Copy link
Collaborator

@mauberti-bc mauberti-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mauberti-bc mauberti-bc merged commit 1c83bb7 into dev Dec 6, 2024
22 of 24 checks passed
@mauberti-bc mauberti-bc deleted the SIMSBIOHUB-644 branch December 6, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants