Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-638: Add Vantage to Techniques (Backend) #1423

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Nov 6, 2024

Links to Jira Tickets

Description of Changes

  • Adds a set of database tables for techniques to have vantages
  • Adds a new table for qualitative attribute options, allowing records to be reused for multiple attributes

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Nov 6, 2024
@mauberti-bc mauberti-bc changed the title SIMSBIOHUB-638: Add Vantage to Techniques SIMSBIOHUB-638: Add Vantage to Techniques (Backend) Nov 15, 2024
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Nov 15, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.60%. Comparing base (0a9a57f) to head (a2dbacc).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
api/src/paths/reference/get/technique-attribute.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1423      +/-   ##
==========================================
+ Coverage   45.49%   45.60%   +0.10%     
==========================================
  Files         842      845       +3     
  Lines       22254    22296      +42     
  Branches     3301     3301              
==========================================
+ Hits        10125    10167      +42     
  Misses      11532    11532              
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Split migration into 2 files.
Add migration to remove duplicate constraint from previous PR.
@NickPhura NickPhura marked this pull request as ready for review November 26, 2024 20:10
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👓

@NickPhura NickPhura merged commit f0cb44e into dev Nov 26, 2024
27 of 41 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-638 branch November 26, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants