Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Show Qualitative Options for Environments on Standards Page #1372

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • The cards did not display the options for qualitative environmental measurements, they only showed the measurement name and description
  • Adds units to quantitative species measurements and environments

Testing Notes

  • The species measurements search is currently broken due to a Critterbase bug related to the keycloak_uuid field
  • Standards page should display options for all qualitative environmental variables, method attributes and species attributes.

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Sep 18, 2024
@mauberti-bc mauberti-bc changed the title BugFix: Show Qualitative Options for Measurements on Standards Page BugFix: Show Qualitative Options for Environments on Standards Page Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 22 lines in your changes missing coverage. Please review.

Project coverage is 48.48%. Comparing base (0918659) to head (e0205c6).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
.../standards/view/methods/MethodStandardsResults.tsx 0.00% 5 Missing ⚠️
...standards/view/species/SpeciesStandardsResults.tsx 0.00% 4 Missing ⚠️
...s/view/environment/EnvironmentStandardsResults.tsx 0.00% 3 Missing ⚠️
app/src/components/loading/LoadingGuard.tsx 87.50% 2 Missing ⚠️
...tandards/view/environment/EnvironmentStandards.tsx 0.00% 2 Missing ⚠️
...eatures/standards/view/methods/MethodStandards.tsx 0.00% 2 Missing ⚠️
...nents/measurements/ConfigureMeasurementColumns.tsx 0.00% 2 Missing ⚠️
...tandards/view/components/AccordionStandardCard.tsx 0.00% 1 Missing ⚠️
...onents/environment/ConfigureEnvironmentColumns.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1372      +/-   ##
==========================================
- Coverage   48.49%   48.48%   -0.01%     
==========================================
  Files         772      772              
  Lines       20714    20728      +14     
  Branches     3127     3131       +4     
==========================================
+ Hits        10045    10051       +6     
- Misses      10523    10531       +8     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura marked this pull request as ready for review September 18, 2024 23:28
mauberti-bc and others added 5 commits September 18, 2024 16:41
Fix bug with LoadingGuard.tsx (was not showing noDataFallback sometimes)
Wrap standards components in LoadingGuard.
Tweak standards skeleton loaders.
Copy link

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧍‍♂️

@NickPhura NickPhura merged commit 430d007 into dev Sep 23, 2024
21 of 22 checks passed
@NickPhura NickPhura deleted the bugFix-environments-standards branch September 23, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants