Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Request Measurements as API User for the Standards Page #1371

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Sep 18, 2024

Links to Jira Tickets

  • N/A

Description of Changes

  • Request measurements from Critterbase as the API user, instead of a keycloak user (which does not exist because the endpoint does not have authentication)

Testing Notes

  • Requires the keycloak_uuid column in Critterbase to be changed to varchar instead of nbchar(32), to prevent the SIMS API user's uuid ("biohub_api") from being padded to 32 characters in Critterbase.

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.49%. Comparing base (87a60fe) to head (9a856f8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1371   +/-   ##
=======================================
  Coverage   48.49%   48.49%           
=======================================
  Files         772      772           
  Lines       20714    20714           
  Branches     3127     3127           
=======================================
  Hits        10045    10045           
  Misses      10523    10523           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@NickPhura NickPhura marked this pull request as ready for review September 18, 2024 23:28
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦁

@NickPhura NickPhura merged commit 4c304eb into dev Sep 18, 2024
39 checks passed
@NickPhura NickPhura deleted the bugFix-standards-page branch September 18, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants