Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Information Banner to Device Keys Dialog #1369

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Add Information Banner to Device Keys Dialog #1369

merged 3 commits into from
Sep 19, 2024

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • Adds an alert banner with more information about how BCTW data retrievals work
  • Makes the device keys button more prominent on the manage telemetry page

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.49%. Comparing base (4c304eb) to head (c53cc00).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...elemetry/device-keys/TelemetryDeviceKeysButton.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1369   +/-   ##
=======================================
  Coverage   48.49%   48.49%           
=======================================
  Files         772      772           
  Lines       20714    20714           
  Branches     3127     3127           
=======================================
  Hits        10045    10045           
  Misses      10523    10523           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Sep 18, 2024
@NickPhura NickPhura marked this pull request as ready for review September 18, 2024 23:30
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔑

Copy link

@NickPhura NickPhura merged commit 0918659 into dev Sep 19, 2024
21 of 22 checks passed
@NickPhura NickPhura deleted the device-keys branch September 19, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants