Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release dev to test #1367

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Release dev to test #1367

merged 8 commits into from
Sep 18, 2024

Conversation

mauberti-bc
Copy link
Collaborator

No description provided.

MacQSL and others added 6 commits September 9, 2024 22:49
- UI components for multi CSV import (Captures / Measurements / Markings)
* add subcount sign manually and by csv import

* update column name for sign

* fix tests

* remove console logs & simplify code

* Add some unit tests to new code column validator logic

* ignore-skip

* Add sign description.
Add manual observation environment column validation.
Fix sql bug preventing any quantitatitve environments from being returned in the search results.
Fix missing openapi quantitative field.
Fix frontend quantitative type.

---------

Co-authored-by: Nick Phura <[email protected]>
* fix ambiguous survey_id reference

* linter
* Initial commit

* Updates

* Initial survey export UIs

* Copy changes from biohub

* Experimental stream

* Updates

* Updates

* Update export backend

* Fix unit test

* ignore-skip

* Tweaks

* Updates to support export stream configs

* Update config

* Working with api strams

* Revert virus scan change

* ignore-skip

* styling for export dialog

* Remove debug log

* Tweaks

* Fix error message

* Update error logging, add unit tests.

* Add more unit tests

---------

Co-authored-by: Macgregor Aubertin-Young <[email protected]>
Co-authored-by: Macgregor Aubertin-Young <[email protected]>
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 45.95041% with 327 lines in your changes missing coverage. Please review.

Project coverage is 48.49%. Comparing base (c6e2f46) to head (87a60fe).
Report is 31 commits behind head on test.

Files with missing lines Patch % Lines
...captures/import-captures/CreateCSVCapturesPage.tsx 0.00% 62 Missing ⚠️
api/src/services/observation-service.ts 5.66% 50 Missing ⚠️
.../dialog/attachments/FileUploadSingleItemDialog.tsx 0.00% 24 Missing ⚠️
...es/surveys/view/survey-export/SurveyExportForm.tsx 7.69% 24 Missing ⚠️
...rt-services/telemetry/export-telemetry-strategy.ts 45.83% 13 Missing ⚠️
...rc/components/file-upload/FileUploadSingleItem.tsx 7.69% 12 Missing ⚠️
...urveys/telemetry/table/TelemetryTableContainer.tsx 0.00% 12 Missing ⚠️
.../surveys/view/survey-export/SurveyExportDialog.tsx 52.00% 12 Missing ⚠️
app/src/hooks/api/useSurveyApi.ts 33.33% 12 Missing ⚠️
.../src/features/projects/view/ProjectAttachments.tsx 31.25% 11 Missing ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             test    #1367      +/-   ##
==========================================
+ Coverage   46.58%   48.49%   +1.90%     
==========================================
  Files         759      772      +13     
  Lines       20382    20714     +332     
  Branches     3123     3127       +4     
==========================================
+ Hits         9495    10045     +550     
- Misses      10309    10523     +214     
+ Partials      578      146     -432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LouisThedroux and others added 2 commits September 18, 2024 09:17
* Added new migration file to add new method lookup values, deprecate old lookup values.

---------

Co-authored-by: Meijer <[email protected]>
Co-authored-by: Thompson <[email protected]>
Co-authored-by: Macgregor Aubertin-Young <[email protected]>
Co-authored-by: Macgregor Aubertin-Young <[email protected]>
Co-authored-by: Nick Phura <[email protected]>
* Split the project/survey report/non-report attachment dialogs into 2 components.
Made 2 new attachment dialogs - one for single items, one for many items.
Added error handling to catch file upload errors.

* Add missing JSDoc.
Fix project/survey regular attachments error display (shows error in the list, not as a popup).

* Add JSDoc.
Add fallback catch to report upload.
Fix error popup not displaying error message in body of dialog for the csv upload dialogs.

---------

Co-authored-by: Macgregor Aubertin-Young <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura marked this pull request as ready for review September 18, 2024 18:12
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪

@mauberti-bc mauberti-bc merged commit 2fc57fb into test Sep 18, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants