TechDebt: Centralize Virus Scan #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1365 +/- ##
==========================================
- Coverage 48.34% 48.28% -0.06%
==========================================
Files 763 763
Lines 20498 20465 -33
Branches 3134 3124 -10
==========================================
- Hits 9909 9882 -27
+ Misses 10437 10431 -6
Partials 152 152 ☔ View full report in Codecov by Sentry. |
|
@mauberti-bc I know we talked about patching the error handling as part of this PR, but on second thought there is no real overlap, so in the interest of small PRs we may as well merge this when its ready. I can just open a separate PR for the frontend changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
Move the virus scan step into the app.ts file, so that it doesn't need to be included in every endpoint that handles file uploads.
Testing Notes
Uploading/Downloading files works as before.
Can use this string (paste into a random txt file) to trigger our APIs file upload virus scans: https://en.wikipedia.org/wiki/EICAR_test_file
I've tested a few places we upload files, and they work as expected. Every file upload goes through the same field and should be handled by the same multer middleware anyways, so if one works they should all work.