Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Migration to add NOT NULL constraint to all uuid columns #1363

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Sep 11, 2024

Description of Changes

  • Created migration to add NOT NULL constraint to all uuid columns
  • Generates a uuid if cell currently holds a NULL value

Testing Notes

  • Run this command to check for existing tables with 'uuid' column.
  • All uuid columns should now be NOT NULL
SELECT * FROM information_schema.COLUMNS WHERE column_name = 'uuid';

Copy link

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.34%. Comparing base (027d8eb) to head (cd5f1ea).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1363   +/-   ##
=======================================
  Coverage   48.34%   48.34%           
=======================================
  Files         763      763           
  Lines       20498    20498           
  Branches     3134     3134           
=======================================
  Hits         9909     9909           
  Misses      10437    10437           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacQSL MacQSL requested a review from NickPhura September 11, 2024 22:32
@MacQSL MacQSL added the Ready For Review PR is ready for review label Sep 11, 2024
Copy link
Collaborator

@mauberti-bc mauberti-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the migration locally and it worked 👍

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MacQSL MacQSL merged commit edb69b0 into dev Sep 16, 2024
23 checks passed
@MacQSL MacQSL deleted the mdBugFix-not-null-uuid-migration branch September 16, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants