Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPI ETL: Map SPI Species Codes to ITIS TSNs #1362

Merged
merged 3 commits into from
Sep 11, 2024
Merged

SPI ETL: Map SPI Species Codes to ITIS TSNs #1362

merged 3 commits into from
Sep 11, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Sep 10, 2024 •
edited
Loading

Links to Jira Tickets

  • N/A

Description of Changes

  • Uses exact matches on scientific name to map SPI species codes to ITIS TSNs
  • Stores the SPI-ITIS mapping in the public schema

Testing Notes

  • Need to update the code to apply migrations to the port-forward spi-test DB and not the local DB instance
  • SPI codes without an ITIS match can be validated by searching for the scientific name at https://itis.gov/ and confirming that no species are returned.

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Sep 10, 2024
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.10%. Comparing base (353675e) to head (1af8493).
Report is 2 commits behind head on test-spi.

Additional details and impacted files 
@@             Coverage Diff              @@
##           test-spi    #1362      +/-   ##
============================================
+ Coverage     47.88%   50.10%   +2.21%     
============================================
  Files           736      736              
  Lines         20015    20015              
  Branches       3146     3146              
============================================
+ Hits           9585    10028     +443     
+ Misses         9825     9819       -6     
+ Partials        605      168     -437

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LouisThedroux LouisThedroux marked this pull request as ready for review September 11, 2024 18:39
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@LouisThedroux LouisThedroux merged commit 2af93d3 into test-spi Sep 11, 2024
15 checks passed
@LouisThedroux LouisThedroux deleted the spi-species-map branch September 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauberti-bc @LouisThedroux