Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Ambiguous Survey ID in Find Animals SQL #1361

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • Updates survey-critter-repository SQL to explicitly reference DB tables in the find animals query

Testing Notes

  • Requests for animal data on the summary page should succeed with a 200 status

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.34%. Comparing base (0d0f2f2) to head (0bf65a2).

Files with missing lines Patch % Lines
api/src/repositories/survey-critter-repository.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1361   +/-   ##
=======================================
  Coverage   48.34%   48.34%           
=======================================
  Files         763      763           
  Lines       20498    20498           
  Branches     3134     3134           
=======================================
  Hits         9909     9909           
  Misses      10437    10437           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacQSL MacQSL marked this pull request as ready for review September 11, 2024 16:05
MacQSL
MacQSL previously approved these changes Sep 11, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩴

Copy link

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauberti-bc mauberti-bc merged commit 027d8eb into dev Sep 11, 2024
21 of 22 checks passed
@mauberti-bc mauberti-bc deleted the bugFix-ambiguous-surveyId branch September 11, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants