Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-587 UI: Multi CSV Upload Page #1357

Merged
merged 12 commits into from
Sep 10, 2024
Merged

SIMSBIOHUB-587 UI: Multi CSV Upload Page #1357

merged 12 commits into from
Sep 10, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Aug 28, 2024

Links to Jira Tickets

Description of Changes

  • Created UI for uploading Capture / Measurement / Marking CSV's
  • Created stateless "FileUploadSingleItem" component to explicitly handle the file upload progress
  • Created "CreateCSVCapturesPage" which handles all three CSV imports

Testing Notes

  • Should be able to import all previous CSV's through the import tool
  • It should only attempt to import Markings / Measurements if Captures CSV succeeds

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 10.81081% with 99 lines in your changes missing coverage. Please review.

Project coverage is 46.32%. Comparing base (c6e2f46) to head (62788b6).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...captures/import-captures/CreateCSVCapturesPage.tsx 0.00% 62 Missing ⚠️
...rc/components/file-upload/FileUploadSingleItem.tsx 0.00% 13 Missing ⚠️
app/src/hooks/api/useSurveyApi.ts 20.00% 12 Missing ⚠️
...rofile/captures/import-captures/utils/templates.ts 0.00% 6 Missing ⚠️
...c/components/file-upload/FileUploadItemContent.tsx 42.85% 0 Missing and 4 partials ⚠️
...file/captures/components/AnimalCapturesToolbar.tsx 0.00% 1 Missing ⚠️
app/src/utils/Utils.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1357      +/-   ##
==========================================
- Coverage   46.58%   46.32%   -0.27%     
==========================================
  Files         759      762       +3     
  Lines       20382    20410      +28     
  Branches     3123     3121       -2     
==========================================
- Hits         9495     9454      -41     
- Misses      10309    10378      +69     
  Partials      578      578              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NickPhura
NickPhura previously approved these changes Sep 9, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐔

Refresh selected critter on bulk import.
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐔 🐔

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MacQSL MacQSL merged commit 407efe1 into dev Sep 10, 2024
19 of 22 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-587-UI-V2 branch September 10, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants