Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB 587: API Measurements #1344

Merged
merged 20 commits into from
Sep 4, 2024
Merged

SIMSBIOHUB 587: API Measurements #1344

merged 20 commits into from
Sep 4, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Aug 20, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 76.72956% with 37 lines in your changes missing coverage. Please review.

Project coverage is 47.17%. Comparing base (bb4f7dd) to head (d9f96f2).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
.../survey/{surveyId}/critters/measurements/import.ts 0.00% 21 Missing ⚠️
...rvices/measurement/import-measurements-strategy.ts 89.21% 4 Missing and 7 partials ⚠️
...surement/import-measurements-strategy.interface.ts 0.00% 3 Missing ⚠️
...mport-services/capture/import-captures-strategy.ts 92.85% 0 Missing and 1 partial ⚠️
...mport-services/marking/import-markings-strategy.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1344      +/-   ##
==========================================
+ Coverage   47.01%   47.17%   +0.16%     
==========================================
  Files         738      741       +3     
  Lines       19887    20014     +127     
  Branches     3062     3084      +22     
==========================================
+ Hits         9350     9442      +92     
- Misses       9969     9997      +28     
- Partials      568      575       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐜

Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐜 🐜

@MacQSL MacQSL merged commit 981ee0c into dev Sep 4, 2024
21 of 22 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-587-Measurements branch September 4, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants