Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecological Units to Survey Focal Species #1343

Merged
merged 11 commits into from
Sep 6, 2024
Merged

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • When a focal species is selected, users can now select multiple ecological units for each focal species.

Testing Notes

  • Should be able to add focal species and ecological units for each focal species
  • If a species does not have any ecological units, the button is disabled

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 19, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 20.83333% with 95 lines in your changes missing coverage. Please review.

Project coverage is 46.58%. Comparing base (e1a31b8) to head (a4eb401).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...species/ecological-units/EcologicalUnitsSelect.tsx 4.34% 22 Missing ⚠️
...ies/components/FocalSpeciesEcologicalUnitsForm.tsx 6.25% 15 Missing ⚠️
...components/species/components/FocalSpeciesForm.tsx 10.00% 9 Missing ⚠️
...eatures/surveys/components/species/SpeciesForm.tsx 11.11% 8 Missing ⚠️
api/src/repositories/survey-repository.ts 30.00% 7 Missing ⚠️
...omponents/species/components/FocalSpeciesAlert.tsx 12.50% 7 Missing ⚠️
api/src/services/survey-service.ts 66.66% 5 Missing and 1 partial ⚠️
...l-information/components/SelectedAnimalSpecies.tsx 0.00% 4 Missing ⚠️
.../observations-table/ObservationsTableContainer.tsx 0.00% 4 Missing ⚠️
...s/ecological-units/EcologicalUnitsOptionSelect.tsx 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1343      +/-   ##
==========================================
- Coverage   46.62%   46.58%   -0.04%     
==========================================
  Files         757      759       +2     
  Lines       20330    20382      +52     
  Branches     3120     3123       +3     
==========================================
+ Hits         9478     9495      +17     
- Misses      10276    10309      +33     
- Partials      576      578       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura marked this pull request as draft August 23, 2024 18:17
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Aug 28, 2024
@NickPhura NickPhura marked this pull request as ready for review September 5, 2024 01:38
@NickPhura NickPhura changed the title Add ecological units to survey focal species Add Ecological Units to Survey Focal Species Sep 5, 2024
Copy link

sonarqubecloud bot commented Sep 6, 2024

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐅

@mauberti-bc mauberti-bc merged commit c6e2f46 into dev Sep 6, 2024
20 of 22 checks passed
@mauberti-bc mauberti-bc deleted the survey-collection-unit branch September 6, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants