Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter measurements search by focal and observed species #1338

Merged
merged 18 commits into from
Sep 3, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Aug 10, 2024

Links to Jira Tickets

Description of Changes

  • New endpoint for retrieving species observed in a survey
  • Allows measurement search to only return measurements that focal species/observed species can have
  • Updates styling of the configure observations table dialog

Testing Notes

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 10, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 30.90909% with 76 lines in your changes missing coverage. Please review.

Project coverage is 46.98%. Comparing base (b856afd) to head (d10c9b8).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ponents/measurements/search/MeasurementsSearch.tsx 0.00% 22 Missing ⚠️
...urements/search/MeasurementsSearchAutocomplete.tsx 0.00% 11 Missing ⚠️
...nents/measurements/ConfigureMeasurementColumns.tsx 0.00% 9 Missing ⚠️
...ponents/data-grid/GenericGridColumnDefinitions.tsx 0.00% 8 Missing ⚠️
...onents/environment/ConfigureEnvironmentColumns.tsx 0.00% 7 Missing ⚠️
.../grid-column-definitions/GridColumnDefinitions.tsx 0.00% 4 Missing ⚠️
app/src/hooks/api/useTaxonomyApi.ts 25.00% 3 Missing ⚠️
app/src/hooks/cb_api/useXrefApi.tsx 0.00% 3 Missing ⚠️
.../observations-table/ObservationsTableContainer.tsx 0.00% 2 Missing ⚠️
...mns/components/general/ConfigureGeneralColumns.tsx 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1338      +/-   ##
==========================================
- Coverage   47.01%   46.98%   -0.03%     
==========================================
  Files         737      738       +1     
  Lines       19810    19894      +84     
  Branches     3048     3067      +19     
==========================================
+ Hits         9313     9347      +34     
- Misses       9929     9979      +50     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc marked this pull request as ready for review August 16, 2024 21:54
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Aug 16, 2024
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIPIT 🚢

@mauberti-bc mauberti-bc merged commit bb198fa into dev Sep 3, 2024
19 of 22 checks passed
@mauberti-bc mauberti-bc deleted the obs-measurements branch September 3, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants