Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Updated API Error Handling In Response #1323

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Small update to the API error handling. In some cases, it would return an empty object instead of any useful error information. Now correctly parses out the error name and message when returning an error response from the API.

Testing Notes

For an error (throw new Error('blah') in the API. See that the response in the frontend network tab shows the error message.

@NickPhura NickPhura requested a review from MacQSL July 15, 2024 19:40
@NickPhura NickPhura changed the title BugFix: Updated Error Handling BugFix: Updated API Error Handling in Response Jul 15, 2024
@NickPhura NickPhura changed the title BugFix: Updated API Error Handling in Response BugFix: Updated API Error Handling In Response Jul 15, 2024
MacQSL
MacQSL previously approved these changes Jul 16, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@MacQSL MacQSL merged commit 650950f into dev Jul 16, 2024
20 checks passed
@MacQSL MacQSL deleted the npBugFix_Error_Handling branch July 16, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants