SIMSBIOHUB-584 Bulk Animals #1319

MacQSL · 2024-06-28T20:54:25Z

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-584

Description of Changes

{List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

{List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

…ter ids

…services.ts

github-actions · 2024-06-28T20:54:36Z

Openshift URLs for the PR Deployment:

api/src/utils/xlsx-utils/worksheet-utils.ts

api/src/services/import-services/import-critters-service.ts

…imals

…v/biohubbc into SIMSBIOHUB-584-Bulk-Animals

api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.ts

…xon responses

api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.ts

api/src/services/critterbase-service.ts

api/src/utils/xlsx-utils/worksheet-utils.ts

NickPhura

🦑

NickPhura

🦀

sonarqubecloud · 2024-07-16T21:41:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MacQSL added 23 commits June 18, 2024 10:41

feat: added new button for manage animals

5af46cf

feat: added new useCsvApi

a873982

feat: added validation for critter csv import

15a9db0

refactor: updated import endpoint and restructured services

126ebca

feat: updated services for critterbase and sims

668a1ec

refactor: moved column utils to shared file

b3db32d

fix: updated createCritters repository method to correctly parse crit…

1dcf2e6

…ter ids

feat: now validating rows with valid tsns

301ea3b

fix: commit before moving shared code to import-critter-service

723c2be

fix: updated dynamic zod validation schema to include collection units

178cd67

feat: commit before creating import critter service

bab449a

refactor: moved logic from survey-critter-service -> import-critters-…

f31165b

…services.ts

feat: added validation for collection units / categories

1c5fed7

fix: updated zod validation config

3ecb71c

feat: successfully imported collection units with CSV

a75a72c

feat: added util for getting column validator specification

99c9224

fix: updated validation methods

6b10903

fix: removed unused util file

6d76680

test: updated tests for column utils and critter importer

addd160

chore: partially done validation tests for importer

92ce028

feat: successfully can import critters from CSV

142a89c

test: updated tests for import and broken survey tests

0f3f132

chore: continuing validation tests

ac80043

MacQSL changed the title ~~Simsbiohub 584 bulk animals~~ SIMSBIOHUB-584 Bulk Animals Jun 28, 2024

MacQSL added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Jun 28, 2024

MacQSL added 3 commits June 28, 2024 14:09

chore: moved tests to correct file

9f2dae1

fix: updated loggin for validation

f41b40f

fix: closing import dialog once upload completes / fails

27a3d96

MacQSL commented Jun 28, 2024

View reviewed changes

api/src/utils/xlsx-utils/worksheet-utils.ts Show resolved Hide resolved

MacQSL added the Ready For Review PR is ready for review label Jul 2, 2024

fix: removed only from test

671016b

NickPhura reviewed Jul 9, 2024

View reviewed changes

api/src/services/import-services/import-critters-service.ts Outdated Show resolved Hide resolved

NickPhura reviewed Jul 9, 2024

View reviewed changes

api/src/services/import-services/import-critters-service.ts Show resolved Hide resolved

NickPhura and others added 5 commits July 9, 2024 14:21

Merge remote-tracking branch 'origin/dev' into SIMSBIOHUB-584-Bulk-An…

69b045c

…imals

fix: case insensitivity

30bf726

fix: pulled remote

995706b

Merge branch 'SIMSBIOHUB-584-Bulk-Animals' of https://github.com/bcgo…

e936fb1

…v/biohubbc into SIMSBIOHUB-584-Bulk-Animals

fix: incorrectly passing project id as survey id

3bf54d4

NickPhura reviewed Jul 15, 2024

View reviewed changes

api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.ts Outdated Show resolved Hide resolved

NickPhura reviewed Jul 15, 2024

View reviewed changes

api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.ts Outdated Show resolved Hide resolved

MacQSL and others added 5 commits July 15, 2024 14:20

fix: fixed create single critter from failing + updated casing for ta…

91eae5c

…xon responses

feat: updated openapi spec for critter import endpoint

c3b1934

fix: updated tests for useTaxonomy

1977292

Move service instantiate below connection open

0a2f984

Move service instantiate below connection open, Con't

856547e

NickPhura reviewed Jul 16, 2024

View reviewed changes

api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.ts Outdated Show resolved Hide resolved

NickPhura reviewed Jul 16, 2024

View reviewed changes

api/src/paths/project/{projectId}/survey/{surveyId}/critters/import.ts Show resolved Hide resolved

NickPhura reviewed Jul 16, 2024

View reviewed changes

api/src/services/critterbase-service.ts Outdated Show resolved Hide resolved

NickPhura reviewed Jul 16, 2024

View reviewed changes

api/src/utils/xlsx-utils/worksheet-utils.ts Outdated Show resolved Hide resolved

feat: updated types for IXLSXCoumnValidator

b79a3c4

NickPhura previously approved these changes Jul 16, 2024

View reviewed changes

fix: removed incorrect type from IXLSXColumnValidator

ec1c7c6

MacQSL dismissed NickPhura’s stale review via ec1c7c6 July 16, 2024 20:04

fix: forgot to remove test property from column validator

e8bccb5

NickPhura approved these changes Jul 16, 2024

View reviewed changes

Merge branch 'dev' into SIMSBIOHUB-584-Bulk-Animals

c5e1341

MacQSL merged commit ab2a851 into dev Jul 16, 2024
20 checks passed

MacQSL deleted the SIMSBIOHUB-584-Bulk-Animals branch July 16, 2024 21:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SIMSBIOHUB-584 Bulk Animals #1319

SIMSBIOHUB-584 Bulk Animals #1319

MacQSL commented Jun 28, 2024 •

edited by NickPhura

Loading

github-actions bot commented Jun 28, 2024

NickPhura left a comment

NickPhura left a comment

sonarqubecloud bot commented Jul 16, 2024

SIMSBIOHUB-584 Bulk Animals #1319

SIMSBIOHUB-584 Bulk Animals #1319

Conversation

MacQSL commented Jun 28, 2024 • edited by NickPhura Loading

Links to Jira Tickets

Description of Changes

Testing Notes

github-actions bot commented Jun 28, 2024

NickPhura left a comment

Choose a reason for hiding this comment

NickPhura left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 16, 2024

Quality Gate passed

MacQSL commented Jun 28, 2024 •

edited by NickPhura

Loading