Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Allow for captures without locations on the Manage Animals page #1318

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Bug fix: Allow for captures without locations on the Manage Animals page #1318

merged 7 commits into from
Jul 5, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Jun 28, 2024 •
edited
Loading

Links to Jira Tickets

  • N/A

Description of Changes

  • Fixes a bug affecting PROD where capture events without location data break the frontend
  • Displays an alert banner above the animal capture map when capture information is missing
  • Resets release location to equal capture location if release location exists but both locations are said to be the same

@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Jun 28, 2024
MacQSL
MacQSL previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and looks good to me!

@NickPhura
Minor update to release_location control. Updated comments to explain…
57e4913 
… capture vs release location business logic.
NickPhura
NickPhura previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦎

NickPhura
NickPhura approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@NickPhura NickPhura merged commit f5aba0f into dev Jul 5, 2024
17 checks passed
@NickPhura NickPhura deleted the animal-bug-fix branch July 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

@MacQSL MacQSL MacQSL left review comments

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauberti-bc @NickPhura @MacQSL