Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-595: Remove project dates and programs #1309

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Jun 21, 2024

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-595

Description of Changes

  • Remove project start and end date from entire app, including database
  • Remove project programs from entire app
  • Removed EML service instead of having to fix tests

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.18%. Comparing base (cfbc84f) to head (a5c09ca).

Files Patch % Lines
api/src/paths/project/list.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1309      +/-   ##
==========================================
+ Coverage   48.98%   49.18%   +0.20%     
==========================================
  Files         641      639       -2     
  Lines       17948    17687     -261     
  Branches     2829     2778      -51     
==========================================
- Hits         8791     8699      -92     
+ Misses       8573     8410     -163     
+ Partials      584      578       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura changed the title Remove project dates and programs SIMSBIOHUB-595: Remove project dates and programs Jun 21, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐒

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
36.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura merged commit a3cb8a7 into dev Jun 21, 2024
18 of 19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-595 branch June 21, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants