Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text input for capture and mortality locations #1308

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Text input for capture and mortality locations #1308

merged 6 commits into from
Jun 21, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Jun 20, 2024 •
edited
Loading

Links to Jira Tickets

  • N/A

Description of Changes

  • Added input textfield boxes to manually enter capture and mortality latitude/longitude values
  • Updated validation of coordinates
  • Bug fix: remove overflow hidden from the telemetry deployments list

Testing Notes

  • There should only ever be one point on the map when adding/editing capture and mortality locations

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Jun 20, 2024
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.00000% with 99 lines in your changes missing coverage. Please review.

Project coverage is 48.98%. Comparing base (d71f5f7) to head (855d829).

Files Patch % Lines
.../components/location/CaptureLocationMapControl.tsx 0.00% 46 Missing ⚠️
...omponents/location/MortalityLocationMapControl.tsx 0.00% 44 Missing ⚠️
app/src/utils/YupSchema.ts 20.00% 4 Missing ⚠️
app/src/components/map/components/DrawControls.tsx 0.00% 2 Missing ⚠️
...profile/components/LatitudeLongitudeTextFields.tsx 0.00% 2 Missing ⚠️
...components/map/components/ImportBoundaryDialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1308      +/-   ##
==========================================
- Coverage   49.15%   48.98%   -0.18%     
==========================================
  Files         640      641       +1     
  Lines       17883    17948      +65     
  Branches     2808     2829      +21     
==========================================
+ Hits         8790     8791       +1     
- Misses       8509     8573      +64     
  Partials      584      584

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Ready For Review PR is ready for review labels Jun 20, 2024
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Jun 20, 2024
@NickPhura
Minor cleanup
855d829 
- remove some unneeded code
- move yup schema check to YupSchema.ts/yup.d.ts
- Move some Feature type checks to dedicated type guard functions
NickPhura
NickPhura approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
35.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura merged commit cfbc84f into dev Jun 21, 2024
16 of 19 checks passed
@NickPhura NickPhura deleted the animal-capture-location branch June 21, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauberti-bc @NickPhura