Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-588 Capture Method / Date Time #1305

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Jun 17, 2024

Related to: Critterbase 588 Capture

Testing notes:

Should be able to create animals, captures and mortalities.
Should be able to update capture / release date time fields.
Should be able to save without failing.

@MacQSL MacQSL changed the title fix: updated capture related components to use capture_time / release… SIMSBIOHUB-588 Capture Method / Date Time Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 13.79310% with 25 lines in your changes missing coverage. Please review.

Project coverage is 49.15%. Comparing base (34cffde) to head (5beb89c).

Files Patch % Lines
...ile/captures/capture-form/edit/EditCapturePage.tsx 0.00% 9 Missing ⚠️
...captures/capture-form/create/CreateCapturePage.tsx 0.00% 5 Missing ⚠️
...capture-card-details/components/ReleaseDetails.tsx 0.00% 4 Missing ⚠️
app/src/utils/datetime.ts 0.00% 4 Missing ⚠️
...capture-card-details/components/CaptureDetails.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1305      +/-   ##
==========================================
- Coverage   49.15%   49.15%   -0.01%     
==========================================
  Files         639      640       +1     
  Lines       17875    17883       +8     
  Branches     2801     2808       +7     
==========================================
+ Hits         8787     8790       +3     
- Misses       8504     8509       +5     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura
Copy link
Collaborator

NickPhura commented Jun 18, 2024

@MacQSL

Noticed a few more things:


Create an animal.
Create a minimal capture (date, comment, location).
Edit capture -> add release date.
Zod Error:

{
  "error": "Zod validation failed.",
  "issues": [
    {
      "code": "invalid_date",
      "path": [0, "release_time"],
      "message": "captures[0].release_time~Invalid date"
    }
  ]
}


Noticed the UI is displaying the times in different timestamps. In this case, I did not specify a capture time, so it was set to some default value. I assume they should both say 12:00 AM.
(It looks like this is only an issue for the capture card, as the mortality card does show the same time in both spots as expected)

image

A similar but slightly different issue when I do specify capture and release times:
Showing the times correctly below, but the title still shows 12:00 AM
image


Everything else seems happy though as far as I can tell.

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@MacQSL MacQSL merged commit d71f5f7 into dev Jun 18, 2024
17 of 19 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-588-Capture branch June 18, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants