-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TechDebt: AWS V3 Update #1304
TechDebt: AWS V3 Update #1304
Conversation
Openshift URLs for the PR Deployment: |
Openshift URLs for the PR Deployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested uploading and deleting files locally and it worked as expected 👍
…into np_techdebt_aws_v3
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1304 +/- ##
==========================================
- Coverage 49.21% 49.16% -0.05%
==========================================
Files 639 637 -2
Lines 17707 17662 -45
Branches 2787 2779 -8
==========================================
- Hits 8714 8684 -30
+ Misses 8409 8399 -10
+ Partials 584 579 -5 ☔ View full report in Codecov by Sentry. |
Tests are fixed! |
Quality Gate failedFailed conditions |
Links to Jira Tickets
n/a
Description of Changes
API
Bump AWS package from V2 to V3.
APP
Remove some attachment related unused code for resubmitting attachments (part of the old biohub publish workflow)
Testing Notes
Reading/Writing files to S3 storage works as before.