Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-569/589: Add Method Techniques and Manage Sampling Information Page #1303

Merged
merged 75 commits into from
Jul 19, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Jun 4, 2024

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-589
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-569

Description of Changes

  • New page to manage both sampling sites and techniques.
    • Techniques are created under a survey, and are applied to a sampling method (as part of creating/editing sampling sites).

Testing Notes

  • CRUD for sampling sites
  • CRUD for techniques

@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Jun 4, 2024
MacQSL and others added 3 commits July 17, 2024 09:21
- Add technique bulk delete endpoint and wire up in frontend
- Update technique endpoints
- Add technique endpoint unit tests
- Remove commended code
@NickPhura NickPhura added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Jul 17, 2024
@NickPhura NickPhura marked this pull request as ready for review July 17, 2024 22:58
@NickPhura
Copy link
Collaborator

  1. Deleting techniques fails "rows was null or undefined, expected rows != null"

    1. Deleting multiple techniques has no effect

    2. In add sampling site page, add sampling method dialog renders with horizontal scroll on half view port

    3. (Maybe out of scope) the sampling sites cards are rendering strangely

@MacQSL (1, 2, and 3) should be fixed. I didnt address 4. Will probably leave that for a separate UI polish ticket.

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶‍🌫️

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@NickPhura NickPhura merged commit 3f9a8a9 into dev Jul 19, 2024
19 of 20 checks passed
@NickPhura NickPhura deleted the method-technique branch July 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants