Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Test to Prod #1300

Merged
merged 13 commits into from
Jun 3, 2024
Merged

Release Test to Prod #1300

merged 13 commits into from
Jun 3, 2024

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Release latest changes from Test to Prod.

Testing Notes

Standard QA.

NickPhura and others added 11 commits May 8, 2024 17:10
@NickPhura
BugFix: Fix observation types (#1284)
a9b6e80 
Fix observation types
@mauberti-bc @NickPhura
Multiple common names & including taxonomic rank on the species card (#…
d396505 
…1230)

Account for multiple common names in BioHub taxon endpoint response
Add rank badge on species card

---------

Co-authored-by: Nick Phura <[email protected]>
@NickPhura
Release Dev to Test
4f91c48 
Release Dev to Test
@MacQSL
SIMSBIOHUB 572 - Telemetry Data Table (#1287)
614fdb5 
SIMSBIOHUB-572 - Telemetry table
SIMSBIOHUB-575 - Fix save on telemetry table
SIMSBIOHUB-542 - Fix project regions
SIMSBIOHUB-545 - Survey progress incorrect font
@LouisThedroux @NickPhura @mauberti-bc
SIMSBIOHUB-567: Add/Support New Observation Environment Attributes (#…
f019719 
…1289)

Add/Support New Observation Environment Attributes
Add migration for environment attribute values from SPI
---------

Co-authored-by: Nick Phura <[email protected]>
Co-authored-by: Macgregor Aubertin-Young <[email protected]>
@MacQSL
SIMSBIOHUB-542 Project Regions (#1290)
566cc77 
- Survey study areas now map to NRM regions for project list
@MacQSL
SIMSBIOHUB-585+586 Bug Fixes (#1294)
80c9c2f 
- Fixed issue with survey edit/create failing when adding animals
- Fixed issue with dialogs incorrectly rendering when saving certain pages
@NickPhura
BugFix: Fix Pipeline Issue (#1295)
2490988 
Update api/app dockerfiles (multi stage builds)
Update to node 20
Bump typescript version to 4.7
@NickPhura
Release Dev to Test - Merge pull request #1297 from bcgov/dev
758dbb6 
Release Dev to Test - Merge pull request #1297 from bcgov/dev
@MacQSL
BugFix: NRM Region mapping fix (#1298)
4791741
@NickPhura
Release Dev to Test - Merge pull request #1299 from bcgov/dev
62fc44f 
Release Dev to Test
@NickPhura NickPhura requested review from MacQSL and mauberti-bc June 3, 2024 16:19
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.08621% with 927 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (949acd9) to head (3b04e0f).
Report is 1 commits behind head on prod.

Files Patch % Lines
app/src/contexts/observationsTableContext.tsx 0.00% 118 Missing ⚠️
app/src/contexts/telemetryTableContext.tsx 0.00% 106 Missing ⚠️
api/src/services/observation-service.ts 6.02% 78 Missing ⚠️
...ponents/data-grid/GenericGridColumnDefinitions.tsx 0.00% 56 Missing ⚠️
...on-row-validation/ObservationRowValidationUtils.ts 5.66% 50 Missing ⚠️
...ironment/search/EnvironmentsSearchAutocomplete.tsx 0.00% 45 Missing ⚠️
...nts/environment/useConfigureEnvironmentColumns.tsx 0.00% 45 Missing ⚠️
...ies/observation-subcount-environment-repository.ts 22.00% 39 Missing ⚠️
...ts/measurements/useConfigureMeasurementColumns.tsx 0.00% 30 Missing ⚠️
...table/configure-columns/ConfigureColumnsButton.tsx 0.00% 21 Missing ⚠️
... and 53 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             prod    #1300      +/-   ##
==========================================
- Coverage   53.12%   52.65%   -0.47%     
==========================================
  Files         562      581      +19     
  Lines       16432    16757     +325     
  Branches     2552     2600      +48     
==========================================
+ Hits         8729     8823      +94     
- Misses       7119     7344     +225     
- Partials      584      590       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MacQSL
MacQSL approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😺

NickPhura added 2 commits June 3, 2024 13:29
@NickPhura
BugFixes: Test QA Fixes (#1301)
70bf407 
Fix funding source repository queries and zod schema validation.
Remove one repo/service function that was unused.
@NickPhura
Release Dev to Test - Merge pull request #1302 from bcgov/dev
3b04e0f 
Release Dev to Test - Merge pull request #1302 from bcgov/dev
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura merged commit 9040c9e into prod Jun 3, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MacQSL MacQSL MacQSL approved these changes

@mauberti-bc mauberti-bc Awaiting requested review from mauberti-bc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickPhura @MacQSL @mauberti-bc @LouisThedroux