SIMSBIOHUB-585+586 Bug Fixes

[MacQSL]

Links to Jira Tickets

• SIMSBIOHUB-585 Cancel Dialog
• SIMSBIOHUB-586 Species Survey Save Bug

Description of Changes

• Fixed bug with confirmation dialog incorrectly rendering when saving project forms
• Fixed bug with survey page not being able to be saved when adding animals
• Created custom hook useUnsavedChangesDialog
• Note: All the forms/pages (maybe 5/6 different places) that were using the confirmation dialog were duplicating very similar code to handle location changes. This seemed like a good place to have a custom hook to handle the confirmation dialog and location change interceptor.

Testing Notes

• Should be able to save a survey when adding animals
• Confirmation dialogs should render for all forms correctly when trying to navigate to a different page.
• Both actions on the confirmation dialogs should work in all situations correctly

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1294-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1294-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1294

[codecov]

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 52.66%. Comparing base (566cc77) to head (1dd93b7).

Files	Patch %	Lines
.../sampling-sites/create/form/SamplingMethodForm.tsx	0.00%	5 Missing ⚠️
app/src/features/surveys/CreateSurveyPage.tsx	0.00%	3 Missing ⚠️
app/src/features/projects/edit/EditProjectPage.tsx	0.00%	2 Missing ⚠️
app/src/features/surveys/edit/EditSurveyPage.tsx	0.00%	2 Missing ⚠️
...vations/sampling-sites/create/SamplingSitePage.tsx	0.00%	2 Missing ⚠️
...tions/sampling-sites/edit/SamplingSiteEditPage.tsx	0.00%	2 Missing ⚠️
...src/features/projects/create/CreateProjectPage.tsx	50.00%	1 Missing ⚠️
app/src/hooks/useUnsavedChangesDialog.tsx	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1294      +/-   ##
==========================================
+ Coverage   52.49%   52.66%   +0.17%     
==========================================
  Files         580      581       +1     
  Lines       16810    16763      -47     
  Branches     2606     2601       -5     
==========================================
+ Hits         8824     8829       +5     
+ Misses       7396     7344      -52     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NickPhura]

🐐

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud