BugFix: Fixes From QA In Test #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1277 +/- ##
==========================================
- Coverage 52.95% 52.91% -0.04%
==========================================
Files 564 564
Lines 16432 16441 +9
Branches 2561 2561
==========================================
- Hits 8701 8700 -1
- Misses 7149 7159 +10
Partials 582 582 ☔ View full report in Codecov by Sentry. |
|
mauberti-bc
added a commit
that referenced
this pull request
May 3, 2024
* Add subcount sign & sampling site list styling changes (#1268) * wip: sample method response metric * wip: observation subcount sign * migration changes & ui updates * migration to add method lookup options * add and edit response metric for sampling methods * order by in sample methods sql * separate sampling sites method and periods into own component * styling sample site list * styling * add method response metric chip to method edit form * styling * make survey areas orange on the survey map * update survey map componenent & include map legend * update survey map legend * colors * method-response-variable * console logs * move geojson transform from zod schema into sql for observation geometry repo * update colours * linter * Merge branch 'dev' of github.com:bcgov/biohubbc into method-response-variable * move legend position * styling sampling site list panel * cleanup * more styling sample periods list * change timelinedot to calendar icon * change observations map marker * styling timeline icons * leaflet sampling site map * icons to indicate geometry type of sampling site * survey map tooltip * undo * remove extra fields from get study area request * remove survey map legend * include start and end date in survey list table * cleanup * console log * Initial working observation import against sampling period * Add better loading/disabled handlers * remove duplicated migration * update styling * linter * Add Knip and SWC * Update import observations * Remove console logs * Remove swc from API to fix unit tests * Remove knip * Remove gulp * Update lock * Add unit tests. fix spelling * Add tests * Fix merge conflicts * import button changes * observation import button styling * include inset sampling site map * sampling site list tsyling * spacing * alternate styling * additionalproperties: false in samplesite openapi spec * remove not null constraint on subcount sign * linter * update survey progress chip deisgn * linter * replace sampling site inset map with survey map component * jsdoc fixes * linter * linter * code smells * code smell * styling * change to direct imports for MUI components * change mui/system to mui/material in imports * prettier * cleanup * sort sampling periods by date and time * typo --------- Co-authored-by: Nick Phura <[email protected]> * Simsbiohub 496 bctw deployments script (#1272) BCTW deployments transferred to SIMS. Uses JQ + JS + Bash to generate SIMS SQL. * BugFix: Fixes From QA In Test (#1277) * Add migration to patch missing observation_subcount records * Update project/survey user search to handle type ahead search * Update clamav scanner library/code * Update error logging * Remove unneeded migration * Tweak logging --------- Co-authored-by: Macgregor Aubertin-Young <[email protected]> Co-authored-by: Mac Deluca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-541
Description of Changes
Fix migration (patching missing subcount records for existing observation records).
Fix project/survey user search (does proper backend typeahead search).
Update the clamav library we use to one that is more supported.
Testing Notes
n/a