Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simsbiohub 496 bctw deployments script #1272

Merged
merged 18 commits into from
May 1, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Apr 16, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@MacQSL MacQSL added the Not Ready For Review Addressing feedback and/or refactoring label Apr 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.95%. Comparing base (016f266) to head (86b455a).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1272   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files         564      564           
  Lines       16432    16432           
  Branches     2561     2561           
=======================================
  Hits         8701     8701           
  Misses       7149     7149           
  Partials      582      582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc
Copy link
Collaborator

Unable to run it locally. I get the following error using git bash on Windows:

$ ./run.sh files/input.dev.json
main.js -> SyntaxError: Unexpected end of JSON input
failed to get console mode for stdin: The handle is invalid.

NickPhura
NickPhura previously approved these changes Apr 24, 2024
@MacQSL MacQSL added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Apr 24, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MacQSL MacQSL merged commit e7530eb into dev May 1, 2024
19 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-496-bctw-deployments-script branch May 1, 2024 17:58
mauberti-bc added a commit that referenced this pull request May 3, 2024
* Add subcount sign & sampling site list styling changes (#1268)

* wip: sample method response metric

* wip: observation subcount sign

* migration changes & ui updates

* migration to add method lookup options

* add and edit response metric for sampling methods

* order by in sample methods sql

* separate sampling sites method and periods into own component

* styling sample site list

* styling

* add method response metric chip to method edit form

* styling

* make survey areas orange on the survey map

* update survey map componenent & include map legend

* update survey map legend

* colors

* method-response-variable

* console logs

* move geojson transform from zod schema into sql for observation geometry repo

* update colours

* linter

* Merge branch 'dev' of github.com:bcgov/biohubbc into method-response-variable

* move legend position

* styling sampling site list panel

* cleanup

* more styling sample periods list

* change timelinedot to calendar icon

* change observations map marker

* styling timeline icons

* leaflet sampling site map

* icons to indicate geometry type of sampling site

* survey map tooltip

* undo

* remove extra fields from get study area request

* remove survey map legend

* include start and end date in survey list table

* cleanup

* console log

* Initial working observation import against sampling period

* Add better loading/disabled handlers

* remove duplicated migration

* update styling

* linter

* Add Knip and SWC

* Update import observations

* Remove console logs

* Remove swc from API to fix unit tests

* Remove knip

* Remove gulp

* Update lock

* Add unit tests. fix spelling

* Add tests

* Fix merge conflicts

* import button changes

* observation import button styling

* include inset sampling site map

* sampling site list tsyling

* spacing

* alternate styling

* additionalproperties: false in samplesite openapi spec

* remove not null constraint on subcount sign

* linter

* update survey progress chip deisgn

* linter

* replace sampling site inset map with survey map component

* jsdoc fixes

* linter

* linter

* code smells

* code smell

* styling

* change to direct imports for MUI components

* change mui/system to mui/material in imports

* prettier

* cleanup

* sort sampling periods by date and time

* typo

---------

Co-authored-by: Nick Phura <[email protected]>

* Simsbiohub 496 bctw deployments script (#1272)

BCTW deployments transferred to SIMS. Uses JQ + JS + Bash to generate SIMS SQL.

* BugFix: Fixes From QA In Test (#1277)

* Add migration to patch missing observation_subcount records
* Update project/survey user search to handle type ahead search
* Update clamav scanner library/code
* Update error logging
* Remove unneeded migration
* Tweak logging

---------

Co-authored-by: Macgregor Aubertin-Young <[email protected]>
Co-authored-by: Mac Deluca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants