Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Cleanup #1231

Merged
merged 10 commits into from
Mar 6, 2024
Merged

UI Cleanup #1231

merged 10 commits into from
Mar 6, 2024

Conversation

jeznorth
Copy link
Contributor

@jeznorth jeznorth commented Mar 5, 2024

Links to Jira Tickets

Description of Changes

  • General UI clean-up and accessibility improvements

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Openshift URLs for the PR Deployment:

@jeznorth jeznorth added the Do Not Merge PR should not be merged label Mar 5, 2024
@jeznorth jeznorth removed the Do Not Merge PR should not be merged label Mar 5, 2024
@jeznorth jeznorth changed the title UI cleanup UI Cleanup Mar 5, 2024
@jeznorth jeznorth requested review from KjartanE and curtisupshall and removed request for KjartanE March 5, 2024 19:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 55.11%. Comparing base (7e103a2) to head (1ce16b3).

Files Patch % Lines
app/src/features/surveys/SurveyPermitForm.tsx 28.57% 1 Missing and 4 partials ⚠️
...res/surveys/components/SurveyFundingSourceForm.tsx 0.00% 5 Missing ⚠️
...p/src/components/species/FocalSpeciesComponent.tsx 0.00% 2 Missing ⚠️
...ts/species/components/SpeciesAutocompleteField.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1231      +/-   ##
==========================================
- Coverage   55.12%   55.11%   -0.01%     
==========================================
  Files         603      603              
  Lines       18272    18270       -2     
  Branches     2810     2810              
==========================================
- Hits        10072    10070       -2     
  Misses       7538     7538              
  Partials      662      662

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curtisupshall
curtisupshall previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

curtisupshall
curtisupshall previously approved these changes Mar 6, 2024
View reviewed changes
@NickPhura
Copy link
Collaborator 

Failed to compile.

Error: Parse Error: <meta name="viewport" content="viewport-fit=cover, width=d evice-width, initial-scale=1.0, minimum-scale=1.0 />

<meta name=" format-detection" content="telephone=no" />
<meta name="msapplication-tap-highlight" content="no" />
<link rel="manifest" href="/manifest.json" />
<link rel="shortcut icon" type="image/png" href="/assets/icon/favicon.ico" / >
<!-- add to homescreen for ios -->
<meta name="apple-mobile-web-app-capable" content="yes" />
<meta name="apple-mobile-web-app-title" content="Species Inventory Managemen t System" />
<meta name="apple-mobile-web-app-status-bar-style" content="black" />
<script defer src="/static/js/main.90fb5321.js"></script><link href="/static/c ss/main.208c3532.css" rel="stylesheet"></head>
<body>
<div id="root"></div>
</body>
</html>

- htmlparser.js:255 HTMLParser.parse
[src]/[html-minifier-terser]/src/htmlparser.js:255:15

- runMicrotasks

- task_queues.js:95 processTicksAndRejections
internal/process/task_queues.js:95:5

- htmlminifier.js:1282 async minify
[src]/[html-minifier-terser]/src/htmlminifier.js:1282:3

- htmlminifier.js:1365 async Object.exports.minify
[src]/[html-minifier-terser]/src/htmlminifier.js:1365:16

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

MacQSL
MacQSL approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhkehhhlesssgo

@jeznorth jeznorth merged commit 5a6a78b into dev Mar 6, 2024
17 checks passed
@jeznorth jeznorth deleted the UI-Cleanup branch March 6, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MacQSL MacQSL MacQSL approved these changes

@curtisupshall curtisupshall curtisupshall approved these changes

@KjartanE KjartanE Awaiting requested review from KjartanE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeznorth @codecov-commenter @NickPhura @curtisupshall @MacQSL