Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple common names & including taxonomic rank on the species card #1230

Merged
merged 14 commits into from
May 10, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Mar 5, 2024

Links to Jira Tickets

None

Description of Changes

  • Replace all references to commonName with commonNames
  • Change commonName type from a string to an array of strings
  • Include taxonomic rank in the Species Card to indicate whether taxon is a species, genus, family, etc.
  • Include kingdom and rank in biohub's taxonomy API response

Testing Notes

Will need to be merged with bcgov/biohubbc-platform#237

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Mar 5, 2024
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running this locally and ran into issues viewing the survey page. Looks like an issue with the open api spec on the view endpoint. It is missing the commonNames property

@mauberti-bc
Copy link
Collaborator Author

I tried running this locally and ran into issues viewing the survey page. Looks like an issue with the open api spec on the view endpoint. It is missing the commonNames property

I should have mentioned that this PR needs to be tested with this BioHub branch: bcgov/biohubbc-platform#237. That fixes the issue for me.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 53.10%. Comparing base (a9b6e80) to head (a660571).

Files Patch % Lines
.../src/components/species/components/SpeciesCard.tsx 0.00% 6 Missing ⚠️
...autocomplete/AsyncAutocompleteDataGridEditCell.tsx 0.00% 4 Missing ⚠️
...ts/data-grid/taxonomy/TaxonomyDataGridEditCell.tsx 0.00% 2 Missing ⚠️
...ts/data-grid/taxonomy/TaxonomyDataGridViewCell.tsx 0.00% 2 Missing ⚠️
api/src/services/survey-service.ts 0.00% 1 Missing ⚠️
...ts/species/components/SpeciesAutocompleteField.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1230      +/-   ##
==========================================
- Coverage   53.12%   53.10%   -0.02%     
==========================================
  Files         562      562              
  Lines       16432    16436       +4     
  Branches     2552     2553       +1     
==========================================
  Hits         8729     8729              
- Misses       7119     7123       +4     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NickPhura NickPhura merged commit d396505 into dev May 10, 2024
17 of 19 checks passed
@NickPhura NickPhura deleted the itis-search branch May 10, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge PR should not be merged Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants