-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple common names & including taxonomic rank on the species card #1230
Conversation
database/src/migrations/release.0.34/api_get_eml_data_package.sql
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running this locally and ran into issues viewing the survey page. Looks like an issue with the open api spec on the view endpoint. It is missing the commonNames
property
app/src/components/data-grid/autocomplete/AsyncAutocompleteDataGridEditCell.tsx
Show resolved
Hide resolved
I should have mentioned that this PR needs to be tested with this BioHub branch: bcgov/biohubbc-platform#237. That fixes the issue for me. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1230 +/- ##
==========================================
- Coverage 53.12% 53.10% -0.02%
==========================================
Files 562 562
Lines 16432 16436 +4
Branches 2552 2553 +1
==========================================
Hits 8729 8729
- Misses 7119 7123 +4
Partials 584 584 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Links to Jira Tickets
None
Description of Changes
Testing Notes
Will need to be merged with bcgov/biohubbc-platform#237