Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-486: Update Manage Animals Species and Observations Table Species Menus with Lastest Component #1224

Merged
merged 8 commits into from
Mar 1, 2024

Conversation

KjartanE
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • updated critter interfaces to contain itis_tsn & itis_scientific_name
  • Integrated Species Auto Complete field on Animals Page for Add new Animal
  • Integrated Species Option Cards on observation species select

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, just had a couple minor comments

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 55.35%. Comparing base (dfbe6e4) to head (bd5f2ca).

Files Patch % Lines
...ts/species/components/SpeciesAutocompleteField.tsx 35.71% 8 Missing and 1 partial ⚠️
...ts/data-grid/taxonomy/TaxonomyDataGridEditCell.tsx 0.00% 3 Missing ⚠️
...survey-animals/form-sections/GeneralAnimalForm.tsx 40.00% 3 Missing ⚠️
...autocomplete/AsyncAutocompleteDataGridEditCell.tsx 0.00% 1 Missing ⚠️
...features/surveys/telemetry/ManualTelemetryList.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1224      +/-   ##
==========================================
+ Coverage   55.29%   55.35%   +0.06%     
==========================================
  Files         592      592              
  Lines       17978    17985       +7     
  Branches     2769     2772       +3     
==========================================
+ Hits         9941     9956      +15     
+ Misses       7378     7368      -10     
- Partials      659      661       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

al-rosenthal
al-rosenthal previously approved these changes Feb 29, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎴

@NickPhura NickPhura added the Ready For Review PR is ready for review label Mar 1, 2024
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@KjartanE KjartanE merged commit c96c865 into dev Mar 1, 2024
17 checks passed
@KjartanE KjartanE deleted the SIMSBIOHUB-486 branch March 1, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants