Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-388, 481: Add loading buttons to edit/create survey + project forms; Access request bug #1221

Merged
merged 27 commits into from
Mar 1, 2024

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Feb 28, 2024

Links to Jira Tickets

Description of Changes

  • SIMSBIOHUB-481: Fixes an error handling bug when creating a SIMS Access Request.
  • SIMSBIOHUB-388: Uses the LoadingButton to show loading state when creating/editing a survey or project.
    • Consolidates the edit and create forms for projects and surveys into a single component (EditProjectForm and EditSurveyForm, respectively)

Testing Notes

  • You should be able to:
    • Create a project
    • Edit a project
    • Create a survey
    • Edit a survey
    • Send an access request successfully, even if GC Notify environment variables are not configured.

@curtisupshall curtisupshall added the Not Ready For Review Addressing feedback and/or refactoring label Feb 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 27.00000% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 55.29%. Comparing base (56a8080) to head (43d5b11).

Files Patch % Lines
app/src/features/projects/edit/EditProjectPage.tsx 0.00% 18 Missing ⚠️
app/src/features/surveys/edit/EditSurveyForm.tsx 5.26% 18 Missing ⚠️
...src/features/projects/create/CreateProjectPage.tsx 38.88% 10 Missing and 1 partial ⚠️
app/src/features/surveys/CreateSurveyPage.tsx 12.50% 7 Missing ⚠️
app/src/features/surveys/edit/EditSurveyPage.tsx 0.00% 7 Missing ⚠️
...c/features/projects/components/ProjectUserForm.tsx 44.44% 3 Missing and 2 partials ⚠️
...src/features/surveys/components/SurveyUserForm.tsx 57.14% 2 Missing and 1 partial ⚠️
app/src/features/projects/edit/EditProjectForm.tsx 75.00% 0 Missing and 2 partials ⚠️
api/src/paths/administrative-activity.ts 66.66% 1 Missing ⚠️
...veys/components/locations/SurveyAreaMapControl.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1221      +/-   ##
==========================================
+ Coverage   55.28%   55.29%   +0.01%     
==========================================
  Files         593      592       -1     
  Lines       18017    17978      -39     
  Branches     2771     2769       -2     
==========================================
- Hits         9960     9941      -19     
+ Misses       7399     7378      -21     
- Partials      658      659       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall changed the title SIMSBIOHUB-388 SIMSBIOHUB-388: Add loading buttons to edit/create survey + project forms Feb 28, 2024
@curtisupshall curtisupshall added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Feb 28, 2024
@curtisupshall curtisupshall marked this pull request as ready for review February 28, 2024 23:52
@curtisupshall curtisupshall changed the title SIMSBIOHUB-388: Add loading buttons to edit/create survey + project forms SIMSBIOHUB-388, 481: Add loading buttons to edit/create survey + project forms; Access request bug Feb 29, 2024
al-rosenthal

This comment was marked as resolved.

al-rosenthal
al-rosenthal previously approved these changes Feb 29, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NickPhura
NickPhura previously approved these changes Feb 29, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickPhura NickPhura dismissed stale reviews from al-rosenthal and themself via 43d5b11 March 1, 2024 02:06
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎟️

@curtisupshall curtisupshall merged commit dfbe6e4 into dev Mar 1, 2024
16 of 17 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-388 branch March 1, 2024 17:07
curtisupshall added a commit that referenced this pull request Mar 25, 2024
* Addresses linting/console errors related to `useEffect` dependencies.
* Fixes a bug introduced by #1221 in which saving edits to a survey causes the old data to be shown while saving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants