Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-424: Publish Documents to BioHub from SIMS #1193

Merged
merged 24 commits into from
Jan 23, 2024
Merged

SIMSBIOHUB-424: Publish Documents to BioHub from SIMS #1193

merged 24 commits into from
Jan 23, 2024

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Jan 15, 2024 •
edited
Loading

Links to Jira Tickets

Description of Changes

  • Send artifacts to BioHub as part of the existing publish workflow.
  • The artifacts are to be sent as separate requests
  • When a survey has attached artifacts, those artifacts are submitted to biohub during publish

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Related PR for the BioHub changes: bcgov/biohubbc-platform#230

@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@KjartanE
SIMSBIOHUB-395: Dev - Bulk Delete Sampling Sites (#1191)
b6ee463 
- Select one or many records
- Bulk action to delete those records.
- Prevent deletion of records that are referenced by other data (e.g. Sampling site is referenced by an observation).
@KjartanE
SIMSBIOHUB-395-2: Select all bulk delete sample sites (#1192)
942f7d1 
* bulk delete sample sites, select all
* pr edit, add indeterminate on checkbox
@KjartanE
Merge branch 'dev' into SIMSBIOHUB-432
f2760f7
@NickPhura NickPhura mentioned this pull request Jan 15, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (c93d780) 57.80% compared to head (8771a3a) 57.29%.

Files Patch % Lines
api/src/services/platform-service.ts 27.77% 26 Missing ⚠️
api/src/models/biohub-create.ts 51.72% 14 Missing ⚠️
api/src/repositories/attachment-repository.ts 20.00% 4 Missing ⚠️
api/src/services/attachment-service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1193      +/-   ##
==========================================
- Coverage   57.80%   57.29%   -0.51%     
==========================================
  Files         591      590       -1     
  Lines       18082    17915     -167     
  Branches     2788     2772      -16     
==========================================
- Hits        10452    10265     -187     
- Misses       6942     6977      +35     
+ Partials      688      673      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curtisupshall
curtisupshall previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickPhura NickPhura added the Do Not Merge PR should not be merged label Jan 18, 2024
@NickPhura NickPhura added Ready For Review PR is ready for review and removed Do Not Merge PR should not be merged labels Jan 19, 2024
@NickPhura
Tweak artifact submit properties
8422635
@NickPhura
Merge branch 'SIMSBIOHUB-432' of https://github.com/bcgov/biohubbc in…
a287c87 
…to SIMSBIOHUB-432
@NickPhura
Minor simplification to platform artifact submission.
64e6d62 
Remove delete artifact from biohub code (was causing regular sims artifact deletion to fail)
@NickPhura
Fix tests.
2b61993 
Add support for submitting description + comment to biohub.
curtisupshall
curtisupshall previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static read of the code looks good to me 📑

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

curtisupshall
curtisupshall approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

al-rosenthal
al-rosenthal approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and it works as expected! 🌮

@NickPhura NickPhura merged commit 000209e into dev Jan 23, 2024
16 of 19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-432 branch January 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtisupshall curtisupshall curtisupshall approved these changes

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@NickPhura NickPhura Awaiting requested review from NickPhura

@MacQSL MacQSL Awaiting requested review from MacQSL

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KjartanE @al-rosenthal @curtisupshall @NickPhura