Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Test to Prod #1130

Merged
merged 96 commits into from
Oct 20, 2023
Merged

Release Test to Prod #1130

merged 96 commits into from
Oct 20, 2023

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Oct 19, 2023

NickPhura and others added 30 commits May 1, 2023 13:53
SIMSBIOHUB-11: Submit project/survey EML when survey/project metadata changes
Added support for Goat total count and moose aerial transect template
* Moved Resources page from /admin/resources to just /resources;

* Added utility functions for building generic URLs and for generating the Login Page URL (historically, we have programatically sent the user to the Keycloak instance);

* Added a /login helper endpoint, which sends the user to the Keycloak instance;

* When unauthenticated access the SIMS application they land on a home page (historically, they are redirected to the Keycloak instance);

* Added repo and service classes for Administrative Activities

* Created the SIMS Landing Page
Updated Funding sources to not require start/end date for First Nations
* Fixes the application URL provided in Access Request email links

* Adds a login endpoint to hook into Keycloak sign-in

* Adds the `useRedirect` hook
Removed some console logs
Updated focal species display values

---------

Co-authored-by: Kjartan <[email protected]>
* Removed some old git workflow files

* Updated keycloak version, which changed it to always being defined (rather than potentially undefined), and so I removed a bunch of unnecessary `?.` when dereferencing the keycloak object.

* Removed a bunch of null user object checks, as the user object would never be undefined.

* Added change_version to the version endpoint (mainly an experimental change, as I never really noticed that var before, but in theory it might let us put a version number in the UI)

* Pulled some taxonomy-service changes from other projects, just misc updated

* Added the BCGov favicon to the react app.

* Added proper error handling to the db setup pipeline step, so it will properly fail the git action if it fails in openshift

* Moved a bunch of old tests from manually specifying mock keycloak auth states, to using the getMockAuthState test helper function
SIMSBIOHUB-24: bugfix
…mary Results or Documents (#1033)

SIMSBIOHUB-15: Submit Request to Resubmit or Remove Observations, Summary Results or Documents
…mpty cells. (#1037)

* Update duplicate key validation rule to account for empty cells.
Send observations input file to Biohub on observation submission
* Removed duplicate code by creating the LoadingButton component as a stand-in for the analogous MUI Lab version

* Refactored the Project and Survey submission components

* Added an error dialog when the request to submit to Biohub fails
* Installed the MUI DataGrid library

* Updated the Projects list table to use the MUI DataGrid

* Updates React from version 16 to 17

* Updated react-scripts from version 3 to version 5

* Updated numerous packages and fixed tests
fixed issue with import pathing
* Validation/transformation updates/cleanup.
* Updates to date handling in transformation code.
…ths, tsconfig, etc. (#1042)

* Update some material import paths.
* Update tsconfig/prettier/eslint versions.
* Remove unused React imports
* Update jest versionss
…s Once They Have Been Submitted (#1043)

* Disabled importing Observations and Summary Results if they have already been submitted to BioHub

* Disabled deleting Observations, Summary Results, Reports or Attachment sif they have already been submitted to BioHub

* Disabled the option to Remove or Resubmit and Obseration, Summary Result, Report or Attachment if it hasn't been submitted to BioHub

* Removed full page reload when navigating from a survey back to the parent project when clicking Back to Project

* Refactored the Remove or Resubmit dialog and related components
Partnerships combined into a single array
Refactored Draft API endpoints
…ects and Surveys (#1051)

* add region tables

* nrm regions inserted, env regions WIP

* functioning env, nrm regions inserted

* remove temp work folder
SIMSBIOHUB-127: Update inferred layers code
* Update MUI to version 5, including updates to component imports and theming
curtisupshall and others added 19 commits October 5, 2023 11:26
#1108)

Removed lead biologist from survey edit and create page
* Removed Animal count indicator from animal dialog title
* Added "ID" as subtitle when editing an animal
* Removed "Created On" column from animal table
* Renamed "Edit Critter Details" action to "Edit Animal"
Fixed issues with users requesting access to the system

---------

Co-authored-by: Nick Phura <[email protected]>
…, causing migration to fail. (#1113)

BugFix: New funding source name field was shorter than old name field, causing migration to fail.
Update observation context loader.
Remove old page layouts, refactor general setup
---------
* Added a trash can icon next to each deployment in the Edit Deployment page. Does not appear on Add Deployment.
* Clicking the trash can will prompt you with a confirm dialogue. Accepting the dialogue should hit an endpoint in bctw api and remove the deployment from the list. If no deployments remain, then the dialogue automatically closes.
* Added verification of device make directly to the yup schema. Was sometimes missing changes to device id before with the previous set up, this seems more robust.
* Added verification of conflicting deployment date ranges directly to yup schema. Similarly to device make, there were certain cases where this check would not happen before submitting the form.
* Fixed some date range checking logic that was missing some overlapping cases, which allowed you to submit the form and get a 500 back.

---------

Co-authored-by: jeznorth <[email protected]>
Co-authored-by: JeremyQuartech <[email protected]>
Co-authored-by: Curtis Upshall <[email protected]>
Co-authored-by: JeremyQuartech <[email protected]>
* Add datagrid autocomplete components
* Add datagrid support for sample site, method, and period columns
* Add time component to data grid.
* Added node-pg float type parser
* Save/Edit datagrid observations working
See sampling sites that have been added to the manage observations interface.
1. User Sees Sampling Sites
2. User Expands and Collapses Sampling Site List Item

Initial edit functionality for individual sampling sites. (Sample Location, Method, Period )
1. User Edits Sampling Site
* Added a View Telemetry button to the actions menu for rows in the animal table. Only visible if animal has deployments. 
* When you click this, it will either show you a fullscreen map view of the telemetry points and tracks for this animal's deployments or show you a small dialog indicating that there are no points to show yet (most likely scenario for newly added critters). Additional bctw-service functions and routes to support grabbing this information from BCTW.
* Points are grouped by deployment id. The deployment id is used to calculate the colour so it is consistent between re-renders. There is also an outline colour to help distinguish points that contrast poorly with the map.
…mary Results Components (#1117)

* Removed import functionality for observations and summary results components.
* Fixed minor issues with action toolbar (h2 toolbar was using an h4 element for the title).
* Fixed language inconsistency with the 'Marked or Known Animals' interface.
* Refactored FloatingPointField component into more flexible CustomNumberField that adds integer support.
* Added more constraints to telemetry device schema to better align with BCTW API limitations.
* Added logic to reduce unnecessary calls to BCTW API from survey animals page.
* Add missing authorization check for project permission.
* Fix funding source endpoint only returning data for system admins.
* Changed authorization to 'SystemUser' for all basic critterbase lookup and xref endpoint
* Removed duplicate / unused critter-data API endpoints
* Misc cleanup

Co-authored-by: JeremyQuartech <[email protected]>
* Fix survey view date response
* Fix unit test
* updated open api spec and validation for project/ survey create
* migration to handle deletion of critters and deployments from a survey
* Update GCNotify and Keycloak environment variables
* add back removed functionality

* Fixed 'Failed to identify authenticated user' test

* Added back numeric type parser to db

* Fixed remaining tests

---------

Co-authored-by: Curtis Upshall <[email protected]>
Co-authored-by: Nick Phura <[email protected]>
Co-authored-by: Nick Phura <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.6% 4.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1130 (0f21439) into prod (8f9e869) will decrease coverage by 5.00%.
Report is 1 commits behind head on prod.
The diff coverage is 85.72%.

@@            Coverage Diff             @@
##             prod    #1130      +/-   ##
==========================================
- Coverage   68.16%   63.16%   -5.00%     
==========================================
  Files         383      536     +153     
  Lines       11882    16367    +4485     
  Branches     2023     2516     +493     
==========================================
+ Hits         8099    10339    +2240     
- Misses       3314     5334    +2020     
- Partials      469      694     +225     
Files Coverage Δ
api/src/__mocks__/db.ts 96.87% <100.00%> (-3.13%) ⬇️
api/src/constants/administrative-activity.ts 100.00% <100.00%> (ø)
api/src/constants/codes.ts 100.00% <ø> (ø)
api/src/constants/database.ts 100.00% <100.00%> (ø)
api/src/constants/notifications.ts 100.00% <100.00%> (ø)
api/src/database/db-utils.ts 83.87% <100.00%> (+8.87%) ⬆️
api/src/json-schema/transformation-schema.ts 100.00% <100.00%> (ø)
api/src/json-schema/validation-schema.ts 100.00% <100.00%> (ø)
api/src/models/project-update.ts 100.00% <100.00%> (+5.76%) ⬆️
api/src/models/project-view.ts 100.00% <100.00%> (ø)
... and 130 more

... and 329 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura NickPhura requested review from curtisupshall, AlfredRosenthal and KjartanE and removed request for curtisupshall October 20, 2023 16:01
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NickPhura NickPhura merged commit 7c44271 into prod Oct 20, 2023
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants