Skip to content

Commit

Permalink
Fix bad tests.
Browse files Browse the repository at this point in the history
Fix css kebab case warning
  • Loading branch information
NickPhura committed Apr 16, 2024
1 parent d173d63 commit dc8352a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
5 changes: 2 additions & 3 deletions api/src/services/bctw-service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import sinon from 'sinon';
import sinonChai from 'sinon-chai';
import {
BctwService,
BCTW_API_HOST,
DELETE_DEPLOYMENT_ENDPOINT,
DEPLOY_DEVICE_ENDPOINT,
GET_CODE_ENDPOINT,
Expand Down Expand Up @@ -84,7 +83,7 @@ describe('BctwService', () => {
const result = await bctwService._makeGetRequest(endpoint);

expect(result).to.equal(mockResponse.data);
expect(mockAxios).to.have.been.calledOnceWith(`${BCTW_API_HOST}${endpoint}`);
expect(mockAxios).to.have.been.calledOnceWith(`${endpoint}`);
});

it('should make an axios get request with params', async () => {
Expand All @@ -98,7 +97,7 @@ describe('BctwService', () => {
const result = await bctwService._makeGetRequest(endpoint, queryParams);

expect(result).to.equal(mockResponse.data);
expect(mockAxios).to.have.been.calledOnceWith(`${BCTW_API_HOST}${endpoint}?param=${queryParams['param']}`);
expect(mockAxios).to.have.been.calledOnceWith(`${endpoint}?param=${queryParams['param']}`);
});
});

Expand Down
6 changes: 3 additions & 3 deletions api/src/services/critterbase-service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { AxiosResponse } from 'axios';
import chai, { expect } from 'chai';
import sinon from 'sinon';
import sinonChai from 'sinon-chai';
import { CritterbaseService, CRITTERBASE_API_HOST, ICritter } from './critterbase-service';
import { CritterbaseService, ICritter } from './critterbase-service';
import { KeycloakService } from './keycloak-service';

chai.use(sinonChai);
Expand Down Expand Up @@ -53,7 +53,7 @@ describe('CritterbaseService', () => {
const result = await cb._makeGetRequest(endpoint, []);

expect(result).to.equal(mockResponse.data);
expect(mockAxios).to.have.been.calledOnceWith(`${CRITTERBASE_API_HOST}${endpoint}?`);
expect(mockAxios).to.have.been.calledOnceWith(`${endpoint}?`);
});

it('should make an axios get request with params', async () => {
Expand All @@ -67,7 +67,7 @@ describe('CritterbaseService', () => {
const result = await cb._makeGetRequest(endpoint, queryParams);

expect(result).to.equal(mockResponse.data);
expect(mockAxios).to.have.been.calledOnceWith(`${CRITTERBASE_API_HOST}${endpoint}?param=param`);
expect(mockAxios).to.have.been.calledOnceWith(`${endpoint}?param=param`);
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ const useStyles = () => {
return {
docTitle: {
display: '-webkit-box',
'-webkit-line-clamp': 2,
'-webkit-box-orient': 'vertical',
WebkitLineClamp: '2',
WebkitBoxOrient: 'vertical',
overflow: 'hidden'
},
docDL: {
Expand Down
4 changes: 2 additions & 2 deletions app/src/features/resources/ResourcesPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ const useStyles = () => {
},
pageTitle: {
display: '-webkit-box',
'-webkit-line-clamp': 2,
'-webkit-box-orient': 'vertical',
WebkitLineClamp: '2',
WebkitBoxOrient: 'vertical',
paddingTop: theme.spacing(0.5),
paddingBottom: theme.spacing(0.5),
overflow: 'hidden'
Expand Down

0 comments on commit dc8352a

Please sign in to comment.