fix: removed optional for taxon body location

bcgov · Dec 20, 2024 · c138cf2 · c138cf2
1 parent db6c944
commit c138cf2
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/api/src/services/import-services/marking/import-markings-service.ts b/api/src/services/import-services/marking/import-markings-service.ts
@@ -63,7 +63,7 @@ export class ImportMarkingsService extends DBService {
         ALIAS: { aliases: ['NICKNAME', 'ANIMAL'] },
         CAPTURE_DATE: { aliases: ['CAPTURE DATE', 'DATE'] },
         CAPTURE_TIME: { aliases: ['CAPTURE TIME', 'TIME'], optional: true },
-        BODY_LOCATION: { aliases: ['BODY LOCATION'], optional: true },
+        BODY_LOCATION: { aliases: ['BODY LOCATION'] },
         MARKING_TYPE: { aliases: ['MARKING TYPE', 'TYPE'], optional: true },
         IDENTIFIER: { aliases: ['ID'], optional: true },
         PRIMARY_COLOUR: { aliases: ['PRIMARY COLOUR'], optional: true },

diff --git a/api/src/services/import-services/marking/marking-header-configs.test.ts b/api/src/services/import-services/marking/marking-header-configs.test.ts
@@ -145,14 +145,6 @@ describe('marking-header-configs', () => {
       expect(result).to.deep.equal([]);
     });
 
-    it('should return no errors for undefined', () => {
-      const cellValidator = getMarkingBodyLocationCellValidator(new Map(), new NestedRecord(), {} as any);
-
-      const result = cellValidator({ cell: undefined } as CSVParams);
-
-      expect(result).to.deep.equal([]);
-    });
-
     it('should return no errors when alias does not map to a survey critter', () => {
       const dictionary = new NestedRecord({ 1: { location: 'uuid' } });
       const surveyAliasMap: any = new Map([['alias', { itis_tsn: 1 }]]);

diff --git a/api/src/services/import-services/marking/marking-header-configs.ts b/api/src/services/import-services/marking/marking-header-configs.ts
@@ -140,10 +140,6 @@ export const getMarkingBodyLocationCellValidator = (
   utils: CSVConfigUtils<MarkingCSVStaticHeader>
 ): CSVCellValidator => {
   return (params: CSVParams) => {
-    if (params.cell === undefined) {
-      return [];
-    }
-
     const rowAlias = String(utils.getCellValue('ALIAS', params.row));
     const aliasTsn = surveyAliasMap.get(rowAlias.toLowerCase())?.itis_tsn;