Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Security Rule Options #251

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Add Security Rule Options #251

merged 7 commits into from
Aug 30, 2024

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Aug 26, 2024 •
edited
Loading

Links to Jira Tickets

  • N/A

Description of Changes

  • Adds Security Rule Categories
  • Adds Security Rules (without conditions, just names and descriptions)

@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

@mauberti-bc
Copy link
Collaborator Author

mauberti-bc commented Aug 27, 2024 •
edited
Loading

@AMEIJER1 Let me know what you think: it seems complex to have separate telemetry/data/dna/etc. rules for each species. It will be much easier to manage security if we just have one rule per species/category, like: Caribou government interest, caribou persecution and harm, grizzly bear persecution and harm, rattlesnake persecution and harm. If we ever need to remove rules after a certain amount of time, we can do things like: remove "caribou" rule where data type = telemetry. A bit of a 180 on our last conversation but I don't think the highly specific rules are sustainable.

@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Aug 27, 2024
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Aug 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mauberti-bc mauberti-bc marked this pull request as ready for review August 28, 2024 23:22
@github-actions GitHub Actions
Copy link

Openshift URLs for the PR Deployment:

NickPhura
NickPhura approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickPhura NickPhura merged commit fa88581 into dev Aug 30, 2024
34 of 37 checks passed
@NickPhura NickPhura deleted the security-rules branch August 30, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauberti-bc @NickPhura @AMEIJER1