Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove auth check from taxonomy endpoints #249

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Remove auth check from taxonomy endpoints #249

merged 1 commit into from
Aug 26, 2024

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • Removes the bearer security from /taxon and taxon/{tsn} paths
  • The SIMS Standards page can be viewed while logged out, but for logged out users to search species on the standards page, the taxonomy search endpoints need to be public

Notes

  • Alternatively, SIMS could send taxonomy requests with a service account token?

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Openshift URLs for the PR Deployment:

@MacQSL MacQSL closed this Aug 21, 2024
@MacQSL MacQSL reopened this Aug 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mauberti-bc mauberti-bc merged commit 75f63fd into dev Aug 26, 2024
50 checks passed
@NickPhura NickPhura deleted the api-security branch August 26, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MacQSL MacQSL MacQSL approved these changes

@NickPhura NickPhura NickPhura approved these changes

Assignees
No one assigned
Labels
Ready For Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauberti-bc @NickPhura @MacQSL