Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Dev to Test #247

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Release Dev to Test #247

merged 1 commit into from
Jun 25, 2024

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Release Dev to Test

Testing Notes

Basic QA.

* Fix common names parsing bug
* Add commonNames parser util function
@NickPhura NickPhura requested a review from MacQSL June 25, 2024 21:36
Copy link

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (c8527c0) to head (f3bad73).
Report is 5 commits behind head on test.

Files Patch % Lines
api/src/services/taxonomy-service.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             test     #247      +/-   ##
==========================================
+ Coverage   68.64%   68.71%   +0.06%     
==========================================
  Files         194      194              
  Lines        4794     4794              
  Branches      637      637              
==========================================
+ Hits         3291     3294       +3     
+ Misses       1369     1368       -1     
+ Partials      134      132       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura merged commit ed31849 into test Jun 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants