BugFix: Common Name Parsing #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #246 +/- ##
==========================================
+ Coverage 68.64% 68.71% +0.06%
==========================================
Files 194 194
Lines 4794 4794
Branches 637 637
==========================================
+ Hits 3291 3294 +3
+ Misses 1369 1368 -1
+ Partials 134 132 -2 ☔ View full report in Codecov by Sentry. |
MacQSL
reviewed
Jun 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
Rename
itis-sort.tstoitis-utils.tsAdd shared util function for parsing common names: correctly handles case where commonNames field is missing from itis response. Updated itis response interface to mark commonNames as optional.
Testing Notes
BioHub taxon endpoints return taxon records as expected, with an emphasis on the commonNames portion containing the expected values.
In SIMS, when adding a taxon to a survey that has no common names (like a higher rank taxon), when you go to edit the survey, the taxon should correctly be returned and show up in the UI. Before this fix, taxons with no common names were not returned at all from one of the biohub taxon endpoints.