Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Dev to Test #244

Merged
merged 2 commits into from
May 13, 2024
Merged

Release Dev to Test #244

merged 2 commits into from
May 13, 2024

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

n/a

Description of Changes

Release latest Dev changes to Test

Testing Notes

Standard QA.

KjartanE and others added 2 commits May 1, 2024 16:16
- Remove all old/unused code from BioHub.
- Validation/Transformation Schemas
- access request endpoints
- administrative activity endpoints/service/repo
- dwc/eml enpoints/service
- remove misc unused code

---------

Co-authored-by: Nick Phura <[email protected]>
* Taxonomy endpoint returns multiple common names
* Add sorting to itis taxon response

---------

Co-authored-by: Nick Phura <[email protected]>
@NickPhura NickPhura requested review from MacQSL and mauberti-bc May 13, 2024 17:21
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 68.64%. Comparing base (5e5e14e) to head (c8527c0).
Report is 4 commits behind head on test.

Files Patch % Lines
api/src/services/taxonomy-service.ts 40.00% 1 Missing and 2 partials ⚠️
api/src/services/itis-service.ts 75.00% 0 Missing and 2 partials ⚠️
api/src/queue/queue.ts 50.00% 1 Missing ⚠️
api/src/services/submission-job-queue-service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             test     #244      +/-   ##
==========================================
+ Coverage   63.52%   68.64%   +5.12%     
==========================================
  Files         267      194      -73     
  Lines        7470     4794    -2676     
  Branches     1039      637     -402     
==========================================
- Hits         4745     3291    -1454     
+ Misses       2470     1369    -1101     
+ Partials      255      134     -121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MacQSL MacQSL closed this May 13, 2024
@MacQSL MacQSL reopened this May 13, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MacQSL MacQSL merged commit 5e9895d into test May 13, 2024
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants