Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-458: Purge Old BioHub Code #243

Merged
merged 7 commits into from
May 1, 2024
Merged

SIMSBIOHUB-458: Purge Old BioHub Code #243

merged 7 commits into from
May 1, 2024

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Mar 27, 2024

Links to Jira Tickets

Description of Changes

  • Remove all old/unused code from BioHub.
  • Validation/Transformation Schemas
  • access request endpoints
  • administrative activity endpoints/service/repo
  • dwc/eml enpoints/service

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.45%. Comparing base (5e5e14e) to head (4180e4f).

Files Patch % Lines
api/src/queue/queue.ts 50.00% 1 Missing ⚠️
api/src/services/submission-job-queue-service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #243      +/-   ##
==========================================
+ Coverage   63.52%   68.45%   +4.93%     
==========================================
  Files         267      193      -74     
  Lines        7470     4758    -2712     
  Branches     1039      630     -409     
==========================================
- Hits         4745     3257    -1488     
+ Misses       2470     1369    -1101     
+ Partials      255      132     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura merged commit dd73aa0 into dev May 1, 2024
18 of 19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-458 branch May 1, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants