Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-459: Fixed save taxonomy repo method #236

Merged
merged 10 commits into from
Feb 12, 2024
Merged

Conversation

curtisupshall
Copy link
Contributor

Links to Jira Tickets

Description of Changes

Fixed a race condition that occurs when two requests try to read/write from the taxon table.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e761319) 63.48% compared to head (3b294c5) 63.52%.

Files Patch % Lines
api/src/app.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #236      +/-   ##
==========================================
+ Coverage   63.48%   63.52%   +0.03%     
==========================================
  Files         267      267              
  Lines        7463     7470       +7     
  Branches     1039     1039              
==========================================
+ Hits         4738     4745       +7     
  Misses       2470     2470              
  Partials      255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KjartanE
KjartanE previously approved these changes Feb 12, 2024
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected!

NickPhura
NickPhura previously approved these changes Feb 12, 2024
NickPhura
NickPhura previously approved these changes Feb 12, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I snuck a tiny change into your PR, just to reduce our logging output in OpenShift

NickPhura
NickPhura previously approved these changes Feb 12, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that should be all of the changes to sneak in... :)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛷

@curtisupshall curtisupshall merged commit 2f5cd0d into dev Feb 12, 2024
21 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-459 branch February 12, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants