-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-459: Fixed save taxonomy repo method #236
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #236 +/- ##
==========================================
+ Coverage 63.48% 63.52% +0.03%
==========================================
Files 267 267
Lines 7463 7470 +7
Branches 1039 1039
==========================================
+ Hits 4738 4745 +7
Misses 2470 2470
Partials 255 255 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I snuck a tiny change into your PR, just to reduce our logging output in OpenShift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that should be all of the changes to sneak in... :)
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛷
Links to Jira Tickets
Description of Changes
Fixed a race condition that occurs when two requests try to read/write from the
taxon
table.