Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security UI Fixes #233

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Security UI Fixes #233

merged 8 commits into from
Jan 22, 2024

Conversation

jeznorth
Copy link
Contributor

Description of Changes

  • Updating language and front-end clean-up for the security interface.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (9084dec) 62.30% compared to head (dda90a9) 62.29%.

Files Patch % Lines
app/src/components/security/SecurityRuleForm.tsx 0.00% 21 Missing ⚠️
...src/components/security/SecurityRuleActionCard.tsx 0.00% 2 Missing ⚠️
app/src/components/security/SecuritiesDialog.tsx 0.00% 1 Missing ⚠️
app/src/components/security/SecurityRuleCard.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #233      +/-   ##
==========================================
- Coverage   62.30%   62.29%   -0.01%     
==========================================
  Files         265      265              
  Lines        7319     7320       +1     
  Branches     1033     1034       +1     
==========================================
  Hits         4560     4560              
- Misses       2513     2514       +1     
  Partials      246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall self-assigned this Jan 22, 2024
curtisupshall
curtisupshall previously approved these changes Jan 22, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

curtisupshall
curtisupshall previously approved these changes Jan 22, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved comments; Tested locally on my machine. Looks good to me

al-rosenthal
al-rosenthal previously approved these changes Jan 22, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jeznorth jeznorth dismissed stale reviews from al-rosenthal and curtisupshall via e54a721 January 22, 2024 22:18
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

@jeznorth jeznorth merged commit 9ef67c6 into dev Jan 22, 2024
19 of 21 checks passed
@NickPhura NickPhura deleted the security-ui-fixes branch September 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants