SIMSBIOHUB-426: Calculate Submission Regions #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dashboard page to load submission data.
…iohubbc-platform into dataset_security_feature
Add tests for service/repo functions.
…iohubbc-platform into dataset_security_feature
al-rosenthal
requested review from
NickPhura,
KjartanE,
curtisupshall and
MacQSL
NickPhura
reviewed
Jan 16, 2024
app/src/features/admin/dashboard/components/UnreviewedSubmissionsTable.tsx
Outdated
Show resolved
Hide resolved
NickPhura
reviewed
Jan 16, 2024
curtisupshall
previously approved these changes
Jan 16, 2024
|
MacQSL
reviewed
Jan 17, 2024
| @@ -189,6 +190,12 @@ const UnreviewedSubmissionsTable = () => { | |||
| <dd>Source:</dd> | |||
| <dt>{submissionRecord.source_system}</dt> | |||
| </Stack> | |||
| {submissionRecord.regions.length && ( | |||
There was a problem hiding this comment.
This will render a "0" if regions have a zero length.
Can be updated to submissionRecord.regions.length > 0
| @@ -200,6 +200,12 @@ const ReviewedSubmissionsTable = () => { | |||
| <dd>Source:</dd> | |||
| <dt>{submissionRecord.source_system}</dt> | |||
| </Stack> | |||
| {submissionRecord.regions.length && ( | |||
There was a problem hiding this comment.
This will render a "0" if regions have a zero length.
Can be updated to submissionRecord.regions.length > 0
| @@ -207,6 +207,12 @@ const PublishedSubmissionsTable = () => { | |||
| <dd>Source:</dd> | |||
| <dt>{submissionRecord.source_system}</dt> | |||
| </Stack> | |||
| {submissionRecord.regions.length && ( | |||
There was a problem hiding this comment.
Same here.
stack overflow example
| @@ -0,0 +1,17 @@ | |||
| -- ******************************************************************* | |||
| -- Procedure: fn_calculate_area_intersect | |||
| -- Purpose: returns true if both geometries intersect by the given tolerance amount (0.4 == 40% coverage) | |||
There was a problem hiding this comment.
"Both" geometries or "either"?
ie: Is it AND vs OR?
MacQSL
reviewed
Jan 17, 2024
database/src/migrations/release.0.8.0/fn_calculate_area_intersect.sql
Outdated
Show resolved
Hide resolved
KjartanE
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
SIMSBIOHUB-426
Description of Changes
region_lookupandsubmission_regionsTesting Notes