425 + 427 - Show / Download Artifacts + Improved Security Rules #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #228 +/- ##
===========================================
+ Coverage 62.06% 75.03% +12.96%
===========================================
Files 264 131 -133
Lines 7208 4650 -2558
Branches 1014 584 -430
===========================================
- Hits 4474 3489 -985
+ Misses 2493 1007 -1486
+ Partials 241 154 -87 ☔ View full report in Codecov by Sentry. |
|
Openshift URLs for the PR Deployment: |
NickPhura
requested review from
NickPhura,
curtisupshall,
KjartanE and
al-rosenthal
and removed request for
NickPhura and
curtisupshall
app/src/features/submissions/components/SubmissionDataGrid/SubmissionDataGrid.tsx
Outdated
Show resolved
Hide resolved
app/src/features/submissions/components/SubmissionDataGrid/useSubmissionDataGridColumns.tsx
Outdated
Show resolved
Hide resolved
NickPhura
reviewed
Jan 12, 2024
app/src/features/submissions/components/SubmissionDataGrid/SubmissionDataGrid.tsx
Outdated
Show resolved
Hide resolved
NickPhura
reviewed
Jan 12, 2024
|
Commented a couple minor nitpicks, but looks great in general! |
NickPhura
reviewed
Jan 12, 2024
api/src/paths/submission/{submissionId}/features/{submissionFeatureId}/signed-url.ts
Outdated
Show resolved
Hide resolved
NickPhura
reviewed
Jan 12, 2024
api/src/paths/submission/{submissionId}/features/{submissionFeatureId}/signed-url.ts
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Description of Changes
425 - Show Documents In Biohub
427 - Add Placeholder Security Rules
Testing Notes