TechDebt: Port Auth Changes From SIMS + Refactor Service Client Auth #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dataset_security_feature #219 +/- ##
============================================================
+ Coverage 61.75% 62.09% +0.34%
============================================================
Files 262 263 +1
Lines 7130 7147 +17
Branches 1007 1008 +1
============================================================
+ Hits 4403 4438 +35
+ Misses 2487 2469 -18
Partials 240 240 ☔ View full report in Codecov by Sentry. |
NickPhura
requested review from
curtisupshall,
al-rosenthal,
jeznorth,
KjartanE and
MacQSL
curtisupshall
approved these changes
Jan 2, 2024
|
al-rosenthal
approved these changes
Jan 3, 2024
KjartanE
approved these changes
Jan 3, 2024
NickPhura
added a commit
that referenced
this pull request
Jan 4, 2024
Continuation of #219. Ported over auth/keycloak changes from SIMS but missed some changes that impacted the pipeline (wouldn't be noticed when running locally).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Links to Jira tickets
n/a
Description of relevant changes
Port Auth changes from SIMS (newer keycloak libraries, etc)
Refactor service client authentication
db-constants.tsfile, which is used to load constants from the database during API initialization (currently only loads service client information, but can be updated to support other constants as needed).Populate submission source_system column from live submission data.
Update seed to mark a pseudo-random number of submissions as reviewed, and a subset of those as published.
UI change for Jer: Change default switch case for security review status to UNSECURED (rather than PENDING), so that the user only ever sees either UNSECURED, SECURED, or PARTIAL status.
Testing
Everything related to authentication works as before, including service clients.
You will need to run a clean build to get the latest database changes.
Have tested the submission of SIMS data to Biohub, and it seems to be working as expected as far as I can tell.