SIMSBIOHUB-400: BioHub Dataset & Security Feature Branch #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Update dashboard page to load submission data.
…iohubbc-platform into dataset_security_feature
Add tests for service/repo functions.
…iohubbc-platform into dataset_security_feature
NickPhura
requested review from
curtisupshall,
MacQSL,
AlfredRosenthal,
al-rosenthal and
jeznorth
and removed request for
AlfredRosenthal
…iohubbc-platform into dataset_security_feature
…ervice-client-auth
…iohubbc-platform into dataset_security_feature
|
Openshift URLs for the PR Deployment: |
Port Auth changes from SIMS (newer keycloak libraries, etc) Refactor service client authentication - No longer relies on any hard-coded keycloak service client values, everything is read in from the database. - Added new db-constants.ts file, which is used to load constants from the database during API initialization (currently only loads service client information, but can be updated to support other constants as needed). Populate submission source_system column from live submission data. - Was hard coded before. Update seed to mark a pseudo-random number of submissions as reviewed, and a subset of those as published. UI change for Jer: Change default switch case for security review status to UNSECURED (rather than PENDING), so that the user only ever sees either UNSECURED, SECURED, or PARTIAL status.
Continuation of #219. Ported over auth/keycloak changes from SIMS but missed some changes that impacted the pipeline (wouldn't be noticed when running locally).
|
KjartanE
approved these changes
Jan 4, 2024
curtisupshall
changed the title
KjartanE
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Added features to review and secure dataset submissions: See New BioHub Submissions; See Completed BioHub Submissions; Complete Review and Publish Subissions; Admin Review Submission Page; Secure Submission; Unsecure Published Dataset. * Added supplementary changes from SIMS: Ports header improvements from SIMS; Ports latest Keycloak changes from SIMS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Review and Secure Dataset Submissions.
Links to Jira tickets
Description of relevant changes