Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-365: SIMS -> BIOHUB Intake Dataset #210

Merged
merged 16 commits into from
Dec 6, 2023
Merged

SIMSBIOHUB-365: SIMS -> BIOHUB Intake Dataset #210

merged 16 commits into from
Dec 6, 2023

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Nov 29, 2023 •
edited by curtisupshall
Loading

Overview

Links to Jira tickets

Description of relevant changes

  • Created endpoint for dataset intake
  • Created API methods to run validation on datasets
  • Created API methods to insert submission and submission features into database

KjartanE and others added 9 commits November 17, 2023 14:56
@KjartanE
initial endpoint for Survey Id submission
357d29a
@KjartanE
create db connect and insert basic submission
3f8b752
@KjartanE
accept new json object
14877d2
@NickPhura @KjartanE
SIMSBIOHUB-374: BioHub Feature Submission Schema (#209)
359c3c6 
* Submission Feature Migrations and Test Seeding
Remove DB_SCHEMA usage in most places.
Remove DB Views
Add Mock test data seed (disabled by default)
@KjartanE
intake clean up / validation / insert
468c0cb
@NickPhura @KjartanE
SIMSBIOHUB-374: BioHub Feature Submission Schema (#209)
6f8e582 
* Submission Feature Migrations and Test Seeding
Remove DB_SCHEMA usage in most places.
Remove DB Views
Add Mock test data seed (disabled by default)
@NickPhura @KjartanE
SIMSBIOHUB-374: BioHub Feature Submission Schema (#209)
0ede86d 
* Submission Feature Migrations and Test Seeding
Remove DB_SCHEMA usage in most places.
Remove DB Views
Add Mock test data seed (disabled by default)
@KjartanE
Merge branch 'dev' into SIMSBIOHUB-365
cd7af43
@KjartanE
update validation
09739f9
@curtisupshall curtisupshall changed the title SIMS -> BIOHUB Intake Dataset SIMSBIOHUB-365: SIMS -> BIOHUB Intake Dataset Dec 4, 2023
curtisupshall
curtisupshall reviewed Dec 4, 2023
View reviewed changes
api/src/paths/dataset/intake.ts Outdated Show resolved Hide resolved
api/src/paths/dataset/intake.ts Outdated Show resolved Hide resolved
api/src/repositories/submission-repository.ts Outdated Show resolved Hide resolved
api/src/services/validation-service.ts Outdated Show resolved Hide resolved
api/src/services/validation-service.ts Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (71c8882) 69.00% compared to head (a798c79) 68.71%.

Files Patch % Lines
api/src/paths/dataset/intake.ts 0.00% 25 Missing ⚠️
api/src/repositories/submission-repository.ts 0.00% 10 Missing ⚠️
api/src/services/validation-service.ts 88.23% 4 Missing and 2 partials ⚠️
api/src/repositories/validation-repository.ts 0.00% 5 Missing ⚠️
api/src/services/submission-service.ts 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #210      +/-   ##
==========================================
- Coverage   69.00%   68.71%   -0.30%     
==========================================
  Files         214      215       +1     
  Lines        6094     6146      +52     
  Branches      938      945       +7     
==========================================
+ Hits         4205     4223      +18     
- Misses       1665     1700      +35     
+ Partials      224      223       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall self-assigned this Dec 4, 2023
al-rosenthal
al-rosenthal previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

NickPhura
NickPhura approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪴

@curtisupshall curtisupshall merged commit c955dec into dev Dec 6, 2023
20 of 22 checks passed
@curtisupshall curtisupshall deleted the SIMSBIOHUB-365 branch December 6, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtisupshall curtisupshall curtisupshall approved these changes

@NickPhura NickPhura NickPhura approved these changes

@al-rosenthal al-rosenthal al-rosenthal left review comments

Assignees

@curtisupshall curtisupshall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KjartanE @NickPhura @al-rosenthal @curtisupshall